[Bug]: Add provider can create a built-in driver's default instance, which has no delete action

Abierto Apto para principiantes
#38,490 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@nateEc ya está trabajando en esto.

Desde el 19/11/2026.

  • #38872 de @nateEc — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
77/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
react, typescript
Área
frontend

Línea de trabajo

Empieza con AddProviderInstanceDialog.tsx y ProviderSettingsPanel.tsx; después, sigue el rastro de cómo defaultInstanceIdForDriver y ProviderInstanceRegistryHydration.deriveProviderInstanceConfigMap identifican las instancias predeterminadas. Reproduce el problema con un proveedor integrado cuya etiqueta no haya cambiado e inspecciona las pruebas existentes para la creación y eliminación de instancias de proveedores. El trabajo estará terminado cuando un proveedor añadido mediante el diálogo tenga una acción clara para eliminarlo y la regresión esté cubierta por una prueba.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What happened

I added four providers through Settings → Providers → Add provider: Pi, Cursor, Antigravity and Kiro. All four now appear in Settings, but none of them has a delete action. Their detail pane only offers "Reset provider settings to default". Instances I added with a custom ID, such as a second Claude account or an ACP Registry agent, do show the trash / "Delete instance" action.

Why this happens
  • Add provider pre-fills the label with the provider's label and derives the instance ID from that label. When the label still equals the provider label, AddProviderInstanceDialog.tsx returns the driver ID itself (pi, cursor, antigravity, kiro, …). Its existingIds set only reserves codex and claudeAgent, so those driver IDs are accepted.
  • That ID is exactly what defaultInstanceIdForDriver returns for the driver, and ProviderInstanceRegistryHydration.deriveProviderInstanceConfigMap always adds a default instance for every built-in driver. The created entry is therefore treated as the driver's default slot, not as an added instance.
  • ProviderSettingsPanel.tsx marks any instance whose ID equals the default ID as isDefault, and only passes onDelete for non-default rows. ProviderInstanceCard renders the trash button only when onDelete is set; default rows get the Reset button instead.
  • Reset does remove the stored entry, but the button and its confirmation only say "Reset … to its defaults", so nothing tells the user it is the only removal path. The row is also the only place that provider can be managed.
Steps to reproduce
  1. Open Settings → Providers.
  2. Click Add provider, choose Pi (or Cursor, Antigravity, Kiro), leave the label unchanged, click Next and Add instance.
  3. Select the new row and open its detail pane.
  4. Only "Reset Pi provider settings" is shown. There is no Delete / trash action.
  5. Clicking Reset asks to reset the provider to its defaults, not to remove it.
Expected behavior

A provider created through Add provider should be deletable like any other added instance. Either the dialog should not derive a built-in driver's default ID for new instances, or a default-slot row with an explicit stored config should also offer Delete.

Actual behavior

The created rows are reset-only and are indistinguishable from built-in defaults, so they look like providers that cannot be deleted.

Version

T3 Code 0.1.9 (desktop), macOS 27.0 arm64. The same code is on main today: AddProviderInstanceDialog.tsx still reserves only codex and claudeAgent, and ProviderSettingsPanel.tsx still renders onDelete only for !isDefault.

Lenguaje dominante
TypeScript
Estrellas
24.8k
Forks
6.4k
Merge medio
4 h 46 min
PR fusionados (30 d)
488

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de pingdotgg/t3code

Todos los issues de pingdotgg/t3code

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.