Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Disallow `assertEmpty` with strict rule `disallowedEmpty` set

Open
#270 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Quiet
Tech stack
php
Domain
testing

Research direction

Start by locating the strict disallowedEmpty rule and the handling of assertEmpty in this PHPStan PHPUnit extension. Check the existing rule tests, then define done as having assertEmpty consistently affected by disallowedEmpty with coverage for the intended behavior.

Written by the indexing model from the issue text.

Description

hey there

I am currently trying to activate the disallowedEmpty rule of the strict package in our code base (over 1k issues 🎉🤯🙈)

While doing that, I found, that the usage of assertEmpty is not affected by this rule. Is this intentionally? Or do you think, it would be an addition that actually makes sense and would make it consistent?

Happy to hear your feedback on this 🙂

best regards 👋

Dominant language
PHP
Stars
544
Forks
58
Avg merge
2d 1h
Merged PRs (30d)
5

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from phpstan/phpstan-phpunit

All issues in phpstan/phpstan-phpunit

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.