false-positive: Call to static method PHPUnit\Framework\Assert::assertCount() with int<0, max> and array will always evaluate to true

Open
#332 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
php
Domain
testing-qa

Research direction

Start by reproducing the reported assertCount call with the supplied PHPDoc types using phpstan/phpstan 2.2.14 and phpstan/phpstan-phpunit 2.0.18. Trace the PHPUnit assertCount rule or entry point that reports the diagnostic, then add or update a regression test so this valid call is no longer reported as always true.

Written by the indexing model from the issue text.

Description

bug

With the method below phpstan since lately reports the false-positive "Call to static method PHPUnit\Framework\Assert::assertCount() with int<0, max> and array will always evaluate to true."

/**
 * @param array<int|string> $expectedKeys
 * @param array<mixed> $actual
 */
public static function assertArrayHasSameKeys(array $expectedKeys, array $actual): void {
  \PHPUnit\Framework\Assert::assertCount(count($expectedKeys), $actual);
  // ...
}

Used versions:
phpstan/phpstan 2.2.14
phpstan/phpstan-phpunit 2.0.18

Dominant language
PHP
Stars
544
Forks
58
Avg merge
2d 1h
Merged PRs (30d)
5

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from phpstan/phpstan-phpunit

All issues in phpstan/phpstan-phpunit

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.