Incorrect resolution of assertInstanceOf with __NAMESPACE__ + string

Open
#27 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
php
Domain
testing

Research direction

Start with the Doctrine\Tests\DBAL\Functional\DataAccessTest case and reproduce the legacy assertInstanceOf(NAMESPACE.'\MyFetchClass', ...) example described in the issue. Trace how the PHPStan PHPUnit rule resolves the string and verify that the resulting class is Doctrine\Tests\DBAL\Functional\MyFetchClass rather than Doctrine\MyFetchClass.

Written by the indexing model from the issue text.

Description

Doctrine is using the following legacy format on some places:

self::assertInstanceOf(__NAMESPACE__.'\\MyFetchClass', $results[0]);

in a test located inside the Doctrine\Tests\DBAL\Functional\DataAccessTest test case.

The above incorrectly resolves as Doctrine\MyFetchClass instead of Doctrine\Tests\DBAL\Functional\MyFetchClass. Replacing with MyFetchClass::class is a workaround.

Dominant language
PHP
Stars
544
Forks
58
Avg merge
2d 1h
Merged PRs (30d)
5

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from phpstan/phpstan-phpunit

All issues in phpstan/phpstan-phpunit

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.