suggest `assertArrayHasKey` after `assertTrue(isset($x))`

Open
#260 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
php
Domain
testing, tooling

Research direction

Search the repository for AssertSameNullExpectedRule and its tests to learn how comparable PHPUnit rules are structured. Then inspect the rule and test conventions for auto-fixes, and add coverage showing the isset assertion is recognized and converted to assertArrayHasKey with its message preserved.

Written by the indexing model from the issue text.

Description

-$this->assertTrue(isset($anything["foo"]), "message");
+$this->assertArrayHasKey("foo", $anything, "message");

similar to AssertSameNullExpectedRule and others

could be auto-fixable.

inspired by rector

Dominant language
PHP
Stars
544
Forks
58
Avg merge
2d 1h
Merged PRs (30d)
5

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from phpstan/phpstan-phpunit

All issues in phpstan/phpstan-phpunit

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.