Tandems should be passed via options.
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- frontend
Research direction
Search the repository for @param {Tandem} tandem and inspect each constructor and call site that passes tandems directly. Convert the identified sites so tandems are supplied through options, then verify that all matching uses follow the options pattern and that the simulation still runs.
Written by the indexing model from the issue text.
Description
This sim passes tandems via a required constructor parameter. This is an old pattern, and should be replaced with passing tandems via options.
Search for @param {Tandem} tandem to find most (all?) of the sites that need to be converted.
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from phetsims/normal-modes
-
dev:typescript priority:5-deferred
Difficulty 5/5 Over a week Newbie friendliness 15/100
phetsims/normal-modes#92 ·
-
status:blocks-sim-publication
Difficulty 1/5 Under an hour Newbie friendliness 55/100
phetsims/normal-modes#90 ·
-
dev:code-review
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
phetsims/normal-modes#89 ·
-
priority:5-deferred type:bug type:multitouch
Difficulty 3/5 1-2 days Newbie friendliness 42/100
phetsims/normal-modes#87 · 1 comment ·
-
priority:5-deferred type:performance
Difficulty 3/5 1-2 days Newbie friendliness 42/100
phetsims/normal-modes#84 · 1 comment ·
All issues in phetsims/normal-modes
Similar issues
-
Design only Leadership Survey SLFS
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
bcgov/digital-journeys#2293 ·
-
Toolkit
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
API Bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ProjectSidewalk/SidewalkWebpage#5556 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
jessepollak/home#1454 ·
Maintainers usually reply within 1 day
-
Mend: dependency security vulnerability untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
opensearch-project/OpenSearch-Dashboards#12822 ·
Maintainers usually reply within 1 day