SpriteGestureController do not process correct coordinate
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 30/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Domain
- audio-video-rtc, mobile
Research direction
Start with moveSprite in SpriteGestureController and the RotationActivity screen that hosts it, then compare how the touch coordinates are mapped against the view size. The issue says a SurfaceView's black letterbox bars make those two values disagree when the video ratio differs from the screen ratio. Done means a sprite that has been shrunk and moved to a corner can be selected again by touch. The issue has no comments, no assignee and no linked pull request, so ask the maintainer before starting.
Written by the indexing model from the issue text.
Description
Describe the bug
In RotationActivity, when trying to move gif or text, the touch event is not correct.
To Reproduce
- Select GIF or text filter.
- To see the wrong result clearly, first rotate phone to horizon, then use 2 fingers to make the target (gif or text) smaller.
- Try to move the target away from the center to the edge (e.g. left down corner).
- Then try to select the target to move again. You will find it is hard to select it.
Additional context
Function moveSprite calculating target coordinate with size of View and coordinate of MotionEvent in touch event.
Since SurfaceView has black part when the video ratio is not equal with the screen ratio,
the size of View and coordinate of MotionEvent do not provide correct value.
- Dominant language
- Kotlin
- Stars
- 3k
- Forks
- 946
- Avg merge
- 4d 6h
- Merged PRs (30d)
- 9
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pedroSG94/RootEncoder
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
pedroSG94/RootEncoder#2213 ·
Maintainers usually reply within 2 days
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
pedroSG94/RootEncoder#2207 · 1 reaction ·
Maintainers usually reply within 2 days
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
pedroSG94/RootEncoder#2203 ·
Maintainers usually reply within 2 days
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
pedroSG94/RootEncoder#2192 · 2 comments ·
Maintainers usually reply within 2 days
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
pedroSG94/RootEncoder#2177 · 44 comments ·
Maintainers usually reply within 2 days
All issues in pedroSG94/RootEncoder
Similar issues
-
documentation good first issue
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
djazairdev/wilayas#23 ·
Maintainers usually reply within 1 day
-
[BUG] Navigation drawer drops library-name suffixes without ellipsis (1.0.8, NVIDIA Shield)Possibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
damontecres/Wholphin#2069 ·
Maintainers usually reply within 1 day
-
Android (vision-camera-location): HybridLocationManager never quits its HandlerThread on disposeOpen
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
margelo/react-native-vision-camera#4217 ·
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
saisaharsh3/Leftovers#13 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 67/100
navikt/esyfo-narmesteleder#700 ·
Maintainers usually reply within 1 day