fix(table): CollapseColumn uses wrong caret icon for expandable row toggle
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 85/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- react, typescript
- Domain
- frontend
Research direction
The toggle is rendered in packages/react-table/src/components/Table/CollapseColumn.tsx, where RhMicronsCaretDownIcon is imported and used; compare it with the tree-view variant in treeRow.tsx, which already uses RhMicronsCaretRightIcon. Swap the import and the JSX element, then check the Table examples in Storybook to confirm the collapsed caret points right and rotates to point down when expanded. Done means the table toggle matches the tree-view caret behavior.
Written by the indexing model from the issue text.
Description
Bug description
CollapseColumn.tsx uses RhMicronsCaretDownIcon for the standard expandable row toggle, resulting in a confusing down→up caret pattern when combined with the -180deg CSS rotation in the PatternFly core CSS package.
This is the same issue that was fixed for the tree-view variant in treeRow.tsx, which correctly uses RhMicronsCaretRightIcon.
Current behavior
In packages/react-table/src/components/Table/CollapseColumn.tsx:
import RhMicronsCaretDownIcon from
'patternfly-react-icons/dist/esm/icons/rh-microns-caret-down-icon';
// ...
<RhMicronsCaretDownIcon /> // wrong icon
Result:
- Collapsed: ▼ (caret-down at 0°)
- Expanded: ▲ (caret-down rotated -180°)
Expected behavior
Should match the tree-view pattern in treeRow.tsx:
import RhMicronsCaretRightIcon from
'patternfly-react-icons/dist/esm/icons/rh-microns-caret-right-icon';
// ...
<RhMicronsCaretRightIcon /> // correct icon
Result:
- Collapsed: ► (caret-right at 0°)
- Expanded: ▼ (caret-right rotated 90°)
Suggested fix
In CollapseColumn.tsx, change RhMicronsCaretDownIcon to RhMicronsCaretRightIcon.
The companion CSS fix is tracked in patternfly/patternfly#8712.
Related
- patternfly/patternfly#8712 — CSS side of this fix (
table.scss-180deg rotation) - patternfly/patternfly#8501 — tree-view table toggle icon direction (fixed)
- patternfly/patternfly#8502 — CSS fix for tree-view + DualListSelector
- patternfly/patternfly#8490 — original tree-view caret revert
AI-generated. Review for accuracy.
@rh-gvincent requested from Slack
Chai persona: Konflux Help
- Dominant language
- TypeScript
- Stars
- 859
- Forks
- 395
- Avg merge
- 3d 13h
- Merged PRs (30d)
- 15
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from patternfly/patternfly-react
-
Bug - PageSidebar - collapsed sidebar is aria-hidden but its navigation links stay in the tab orderPossibly taken @Sophran-fbj claimed this 4 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
patternfly/patternfly-react#12693 ·
Maintainers usually reply within 1 day
-
Bug - Label - Doesn't allow ref forwardingPossibly taken @tarunvashishth claimed this 28 days ago. OpenPF Team Stale
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
patternfly/patternfly-react#12651 · 1 comment ·
Maintainers usually reply within 1 day
-
Bug - [Menu] - Flyout stays open when hovering a disabled itemPossibly taken @fallmo claimed this 64 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
patternfly/patternfly-react#12637 · 1 comment ·
Maintainers usually reply within 1 day
-
PF Team Stale
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
patternfly/patternfly-react#12617 · 2 comments ·
Maintainers usually reply within 1 day
-
PF Team Stale
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
patternfly/patternfly-react#12610 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
All issues in patternfly/patternfly-react
Similar issues
-
[Site] Active section detection should respect scroll-margin-topPossibly taken A pull request linked to this issue is open or already merged. Openarea/web reproduced type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
anomalyco/opencode#65384 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
swc-project/swc-ai-issues#1001 ·
-
check:passed streams:add
Difficulty 1/5 Under an hour Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
CLI OAuth login fails behind an authenticating proxy: GET /api/v1/user omits Proxy-AuthorizationOpen
Difficulty 1/5 Under an hour Newbie friendliness 85/100
lightdash/lightdash#33086 · 1 comment ·
Maintainers usually reply within 1 day
-
assessment bug course exercise programming
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
Maintainers usually reply within 1 day