fix(table): CollapseColumn uses wrong caret icon for expandable row toggle

Open Beginner friendly
#12,727 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@redhat-chai-bot is already working on this.

Since Nov 21, 2026.

  • #12728 by @redhat-chai-bot — open

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
85/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
react, typescript
Domain
frontend

Research direction

The toggle is rendered in packages/react-table/src/components/Table/CollapseColumn.tsx, where RhMicronsCaretDownIcon is imported and used; compare it with the tree-view variant in treeRow.tsx, which already uses RhMicronsCaretRightIcon. Swap the import and the JSX element, then check the Table examples in Storybook to confirm the collapsed caret points right and rotates to point down when expanded. Done means the table toggle matches the tree-view caret behavior.

Written by the indexing model from the issue text.

Description

Bug description

CollapseColumn.tsx uses RhMicronsCaretDownIcon for the standard expandable row toggle, resulting in a confusing down→up caret pattern when combined with the -180deg CSS rotation in the PatternFly core CSS package.

This is the same issue that was fixed for the tree-view variant in treeRow.tsx, which correctly uses RhMicronsCaretRightIcon.

Current behavior

In packages/react-table/src/components/Table/CollapseColumn.tsx:

import RhMicronsCaretDownIcon from
  'patternfly-react-icons/dist/esm/icons/rh-microns-caret-down-icon';
// ...
<RhMicronsCaretDownIcon />  // wrong icon

Result:

  • Collapsed: ▼ (caret-down at 0°)
  • Expanded: ▲ (caret-down rotated -180°)

Expected behavior

Should match the tree-view pattern in treeRow.tsx:

import RhMicronsCaretRightIcon from
  'patternfly-react-icons/dist/esm/icons/rh-microns-caret-right-icon';
// ...
<RhMicronsCaretRightIcon />  // correct icon

Result:

  • Collapsed: ► (caret-right at 0°)
  • Expanded: ▼ (caret-right rotated 90°)

Suggested fix

In CollapseColumn.tsx, change RhMicronsCaretDownIcon to RhMicronsCaretRightIcon.

The companion CSS fix is tracked in patternfly/patternfly#8712.

Related

  • patternfly/patternfly#8712 — CSS side of this fix (table.scss -180deg rotation)
  • patternfly/patternfly#8501 — tree-view table toggle icon direction (fixed)
  • patternfly/patternfly#8502 — CSS fix for tree-view + DualListSelector
  • patternfly/patternfly#8490 — original tree-view caret revert

AI-generated. Review for accuracy.

@rh-gvincent requested from Slack

Chai persona: Konflux Help

Dominant language
TypeScript
Stars
859
Forks
395
Avg merge
3d 13h
Merged PRs (30d)
15

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from patternfly/patternfly-react

All issues in patternfly/patternfly-react

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.