Table - support for small toggle using ActionsColumn
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- react, typescript
- Domain
- frontend
Research direction
Start in packages/react-table/src/components/Table/ActionsColumn.tsx, especially the default toggle area linked in the issue. Compare the existing custom-toggle path with the requested size control, then verify that compact tables can use a small toggle without affecting regular tables. Done means the default toggle supports the requested size while preserving current behavior.
Written by the indexing model from the issue text.
Description
Compact tables should use compact actions to achieve proper alignment. Regular actions will result in a small misalignment.
The default menu toggle in ActionsColumn component doesn't appear to have support for changing its size, so it causes a misalignment when used in compact tables. It would be great to be able pass a prop to this component to control the default toggle size.
@thatblindgeye I opened this issue before I saw your comment in https://github.com/patternfly/patternfly/issues/7267#issuecomment-2552073848
not sure if we expose a way to adjust the size of a kebab toggle in a table -- EDIT: technically we do as you can pass a custom toggle in
Seems like it might be useful to support a small toggle here, but feel free to close this if you think passing a custom toggle resolves this issue. https://github.com/patternfly/patternfly-react/blob/4d61988b459a747a05cd27a56ceecfea65b87612/packages/react-table/src/components/Table/ActionsColumn.tsx#L101-L109
Jira Issue: PF-4559
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from patternfly/patternfly-react
-
PF Team
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
patternfly/patternfly-react#12651 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
patternfly/patternfly-react#12637 ·
-
PF Team
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
patternfly/patternfly-react#12610 · 1 comment · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
patternfly/patternfly-react#12600 ·
-
PF Team Stale
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
patternfly/patternfly-react#12550 · 1 comment ·
All issues in patternfly/patternfly-react
Similar issues
-
clawsweeper:linked-pr-open clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:message-loss issue-rating: 🦞 diamond lobster maturity:stable P2
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#616 ·
-
ZCode 3.14.3 に対応する Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
supermomonga/zcode-acp#24 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
growthbook/growthbook#7100 ·
-
triage
Difficulty 1/5 1-3 hours Newbie friendliness 88/100