Crash on readying up with a duplicated input config
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 30/100
Research direction
Start with client/src/Player.lua:243 in restrictInputs, then trace how input claims are cleared around match end and how readying up reaches that function through client/src/BattleRoom.lua:396 and client/src/MatchParticipant.lua:120. Done means readying up with multiple input configs for the same controller no longer crashes with the duplicate-claim error.
Written by the indexing model from the issue text.
Description
Not entirely sure how but exciting either way.
10/03/24 08:46:18.562 DEBUG:Popping scene Game2pVs, new active scene is CharacterSelect2p
10/03/24 08:46:18.838 INFO:Stack Trace:
[C]: in function 'error'
client/src/Player.lua:243: in function 'restrictInputs'
client/src/BattleRoom.lua:396: in function 'callback'
common/lib/signal.lua:36: in function 'emitSignal'
client/src/MatchParticipant.lua:120: in function 'setWantsReady'
client/src/scenes/CharacterSelect.lua:171: in function 'onSelect'
client/src/ui/Grid.lua:64: in function 'onSelect'
client/src/ui/GridCursor.lua:156: in function 'receiveInputs'
client/src/scenes/CharacterSelect.lua:899: in function 'update'
client/src/NavigationStack.lua:186: in function 'update'
client/src/Game.lua:281: in function 'update'
main.lua:63: in function 'update'
client/src/CustomRun.lua:118: in function 'runInternal'
DefaultLoveRunFunctions.lua:55: in function <DefaultLoveRunFunctions.lua:53>
[C]: in function 'xpcall'
Username: bramp
Theme: Panel Attack Modern
Error Message: client/src/Player.lua:243: Player 2 is trying to claim a second input configuration
Engine Version: 047
Build Version: canary 1727918953
Operating System: OS: OS X
Love Version: 12.0.0
Renderer Info: Metal;2.1;;Intel(R) Iris(TM) Plus Graphics 640
UTC Time: 2024-10-03 12:46:18
Scene: CharacterSelect2p
BattleRoom Info:
Online: true
Spectating: false
All assets loaded: true
State: 1
Players:
P1:
Player Number: 2
Panels: pdx_panels_crisp_basic
Selected Character: pa_characters_bumpty
Character: pa_characters_bumpty
Selected Stage: PAQR_Flare
Stage: PAQR_Flare
isLocal: true
wantsReady: true
P2:
Player Number: 1
Panels: pdx_panels_crisp_basic
Selected Character: __RandomCharacter
Character: pa_characters_wiggler
Selected Stage: __RandomStage
Stage: PAQR_Lip
isLocal: false
wantsReady: true
By happenstance I know that Bramp has multiple input configs for the same controller:
keysV3(1).json
But swap1 is the same on all of them.
Based on the timings in the crash log, the game clearly should've easily managed to clear the input claim from the previous game as that happens on match end, not on popping the scene and there were a good 2s between sending the game over to the server and the crash.
- Dominant language
- Lua
- Stars
- 30
- Forks
- 20
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 17
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from panel-attack/panel-game
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
panel-attack/panel-game#822 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
panel-attack/panel-game#779 ·
Maintainers usually reply within 1 day
-
bug Client-side priority: 0 - high
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
panel-attack/panel-game#776 ·
Maintainers usually reply within 1 day
-
enhancement priority: 1 - middle
Difficulty 4/5 3-5 days Newbie friendliness 48/100
panel-attack/panel-game#821 ·
Maintainers usually reply within 1 day
-
Animation scenes draw every part separately, costing hundreds of draw calls a framePossibly taken @JamesVanBoxtel claimed this 4 days ago. OpenClient-side enhancement graphics
panel-attack/panel-game#814 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in panel-attack/panel-game
Similar issues
-
slice weekend
Difficulty 2/5 1-3 hours Newbie friendliness 71/100
Life-Framework/Life-Framework#3212 ·
Maintainers usually reply within 1 day
-
bug discord guide:01b-riverglades locale:enUS triage v4.1.1
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
petertriho/nvim-scrollbar#127 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100