Crash on readying up with a duplicated input config

Abierto
#524 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
30/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
lua
Área
game-dev

Línea de trabajo

Start with client/src/Player.lua:243 in restrictInputs, then trace how input claims are cleared around match end and how readying up reaches that function through client/src/BattleRoom.lua:396 and client/src/MatchParticipant.lua:120. Done means readying up with multiple input configs for the same controller no longer crashes with the duplicate-claim error.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug Client-side needs repro priority: 1 - middle

Not entirely sure how but exciting either way.

10/03/24 08:46:18.562 DEBUG:Popping scene Game2pVs, new active scene is CharacterSelect2p
10/03/24 08:46:18.838  INFO:Stack Trace: 
	[C]: in function 'error'
	client/src/Player.lua:243: in function 'restrictInputs'
	client/src/BattleRoom.lua:396: in function 'callback'
	common/lib/signal.lua:36: in function 'emitSignal'
	client/src/MatchParticipant.lua:120: in function 'setWantsReady'
	client/src/scenes/CharacterSelect.lua:171: in function 'onSelect'
	client/src/ui/Grid.lua:64: in function 'onSelect'
	client/src/ui/GridCursor.lua:156: in function 'receiveInputs'
	client/src/scenes/CharacterSelect.lua:899: in function 'update'
	client/src/NavigationStack.lua:186: in function 'update'
	client/src/Game.lua:281: in function 'update'
	main.lua:63: in function 'update'
	client/src/CustomRun.lua:118: in function 'runInternal'
	DefaultLoveRunFunctions.lua:55: in function <DefaultLoveRunFunctions.lua:53>
	[C]: in function 'xpcall'
Username: bramp
Theme: Panel Attack Modern
Error Message: client/src/Player.lua:243: Player 2 is trying to claim a second input configuration
Engine Version: 047
Build Version: canary 1727918953
Operating System: OS: OS X
Love Version: 12.0.0
Renderer Info: Metal;2.1;;Intel(R) Iris(TM) Plus Graphics 640
UTC Time: 2024-10-03 12:46:18
Scene: CharacterSelect2p

BattleRoom Info: 
  Online: true
  Spectating: false
  All assets loaded: true
  State: 1
  Players: 
    P1: 
      Player Number: 2
      Panels: pdx_panels_crisp_basic
      Selected Character: pa_characters_bumpty
      Character: pa_characters_bumpty
      Selected Stage: PAQR_Flare
      Stage: PAQR_Flare
      isLocal: true
      wantsReady: true
    P2: 
      Player Number: 1
      Panels: pdx_panels_crisp_basic
      Selected Character: __RandomCharacter
      Character: pa_characters_wiggler
      Selected Stage: __RandomStage
      Stage: PAQR_Lip
      isLocal: false
      wantsReady: true

By happenstance I know that Bramp has multiple input configs for the same controller:
keysV3(1).json
But swap1 is the same on all of them.
Based on the timings in the crash log, the game clearly should've easily managed to clear the input claim from the previous game as that happens on match end, not on popping the scene and there were a good 2s between sending the game over to the server and the crash.

Lenguaje dominante
Lua
Estrellas
30
Forks
20
Merge medio
3 d 15 h
PR fusionados (30 d)
17

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de panel-attack/panel-game

Todos los issues de panel-attack/panel-game

Issues similares

Más issues de Lua

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.