Inverted logic for assigning DHCPv6 addresses to techports works by accident
Maintainers usually reply within 5 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust
- Domain
- networking
Research direction
Start in tfportd/src/netsupport.rs around lines 88-91, then read the callsite in tfportd/src/techport.rs around lines 129-138. Confirm how each techport name is passed and invert the address-selection logic so the intended interface is selected directly. Done means DHCPv6 addresses sync to their corresponding techports without relying on the two-call interaction; run the relevant project tests afterward.
Written by the indexing model from the issue text.
Description
Ry and I found this one today. The logic for finding DHCPv6 addresses on the techports to sync to the switch has this snippet:
That skips the address if its interface starts with the argument, ifname. But looking at the callsite, this works by accident because here:
we're calling it twice, once for each techport. So when the looped ifname is techport0 we find the address for techport1, and vice versa. It works, but by accident, and we should invert the logic.
- Dominant language
- Rust
- Stars
- 20
- Forks
- 3
- Avg merge
- 8h 29m
- Merged PRs (30d)
- 2
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from oxidecomputer/dendrite
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
oxidecomputer/dendrite#375 ·
Maintainers usually reply within 5 days
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
oxidecomputer/dendrite#369 ·
Maintainers usually reply within 5 days
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
oxidecomputer/dendrite#368 ·
Maintainers usually reply within 5 days
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
oxidecomputer/dendrite#359 · 1 comment ·
Maintainers usually reply within 5 days
-
One build multiple ASICsPossibly taken @cfzimmerman claimed this 22 days ago. Open
oxidecomputer/dendrite#355 · 1 comment · 1 reaction · 1 assignee ·
Maintainers usually reply within 5 days
All issues in oxidecomputer/dendrite
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
solana-foundation/pay-kit#341 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
anthropics/buffa#487 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
arkworks-rs/algebra#1161 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
lbjlaq/Antigravity-Manager#3525 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
rustdesk/rustdesk-server#708 ·