Deleting a link shouldn't fail if the transceiver isn't present
Maintainers usually reply within 5 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 65/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust
- Domain
- backend, networking
Research direction
The issue points to dpd/src/link.rs lines 1785-1799 where the transceiver's MPN is fetched. Start by examining the link reconciler logic around link deletion. Look for error handling on Missing transceiver and modify to allow deletion to proceed. Run existing tests for link deletion to ensure the change doesn't break existing functionality.
Written by the indexing model from the issue text.
Description
Dendrite's link reconciler attempts to match the configured and "plumbed" settings for each link. One of the first things it does is try to fetch transceiver's MPN here:
That fails with Err(DpdError::Missing) if the transceiver isn't present. That's reasonable when trying to create a link, but it blocks deleting a link if the transceiver has been unplugged. We should continue attempting to delete the link in this case.
- Dominant language
- Rust
- Stars
- 20
- Forks
- 3
- Avg merge
- 8h 29m
- Merged PRs (30d)
- 2
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from oxidecomputer/dendrite
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
oxidecomputer/dendrite#380 ·
Maintainers usually reply within 5 days
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
oxidecomputer/dendrite#369 ·
Maintainers usually reply within 5 days
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
oxidecomputer/dendrite#368 ·
Maintainers usually reply within 5 days
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
oxidecomputer/dendrite#359 · 1 comment ·
Maintainers usually reply within 5 days
-
One build multiple ASICsPossibly taken @cfzimmerman claimed this 23 days ago. Open
oxidecomputer/dendrite#355 · 1 comment · 1 reaction · 1 assignee ·
Maintainers usually reply within 5 days
All issues in oxidecomputer/dendrite
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
bytecodealliance/wasmtime#14433 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day