Connect TCP with an invalid address is silent in the event log
Maintainers usually reply within 3 days
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 77/100
Research direction
Start with connect_tcp_with_validation_and_save in relay/src/update.rs, then read tcp_validation_text in relay/src/view.rs and validate_tcp_addr in relay/src/state.rs. Trace how connection failures reach the event log and how validation errors are displayed. Done means rejected empty and malformed addresses appear in Recent events with distinct messages.
Written by the indexing model from the issue text.
Description
Describe the bug
Pressing Connect TCP with an empty or malformed address does nothing visible in the event log. No connection is attempted and no entry is recorded, so the GUI looks like it ignored the press.
connect_tcp_with_validation_and_save (relay/src/update.rs:13) validates first. On failure it sets tcp_addr_validation_error and returns without calling tcp_connect, so none of the paths that normally report a connection problem are reached. The only feedback is one line of plain text rendered by tcp_validation_text (relay/src/view.rs:192), between the address box and the buttons, which is easy to miss.
The event log panel added in #183 exists so connection failures are visible. This is the one connection failure that never reaches it.
To Reproduce
- Start the relay.
- Leave the address box untouched. The greyed
127.0.0.1:9999is placeholder text, not a value, so the field is empty. - Press
Connect TCP. - Nothing appears in Recent events. The mock server never reports a connection. Pressing
Check TCP Connection Statusdoes nothing, because there is no connection to check.
Expected behavior
A rejected address is recorded in the event log like every other connection failure, and the message distinguishes an empty field from a malformed one.
Additional context
The empty-field case is the one that costs time, because validate_tcp_addr (relay/src/state.rs:345) returns the same "Invalid IP address" text for an empty string as for a typo, which reads as though something was typed wrong rather than not typed at all.
Hit while testing #234: roughly half an hour went to diagnosing a relay that appeared not to connect, with nothing in the log to work from.
- Dominant language
- Python
- Stars
- 4
- Forks
- 9
- Avg merge
- 4d 17h
- Merged PRs (30d)
- 7
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from oss-slu/PilotDataSynchronization
-
area:docs area:xplane-plugin documentation needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
oss-slu/PilotDataSynchronization#259 ·
Maintainers usually reply within 3 days
-
cluster_pilots.py shows a traceback for a bad --k and leaves outputs when --truth is invalidPossibly taken A pull request linked to this issue is open or already merged. Openarea:ml bug python
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
oss-slu/PilotDataSynchronization#232 ·
Maintainers usually reply within 3 days
-
Document running the Python listener on a second PCPossibly taken @Omanhene20 claimed this 3 days ago. Openarea:docs area:ml area:relay documentation needs-triage
Difficulty 3/5 1-2 days Newbie friendliness 70/100
oss-slu/PilotDataSynchronization#264 · 1 assignee ·
Maintainers usually reply within 3 days
-
data_logger stops with a traceback if its CSV is open in ExcelPossibly taken @jmacd867 claimed this 10 days ago. Openarea:ml bug needs-triage python
oss-slu/PilotDataSynchronization#263 · 1 assignee ·
Maintainers usually reply within 3 days
-
baton_debug.log logs every sample, even with nothing connected, and grows without limitPossibly taken @Omanhene20 claimed this 3 days ago. Openarea:xplane-plugin enhancement needs-triage rust
Difficulty 4/5 3-5 days Newbie friendliness 56/100
oss-slu/PilotDataSynchronization#262 · 1 assignee ·
Maintainers usually reply within 3 days
All issues in oss-slu/PilotDataSynchronization
Similar issues
-
bug drawing-tools
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
cofade/open-garden-planner#827 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
bug documentation good first issue help wanted testing
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
hololinked-dev/hololinked#213 ·
-
Show evidence time and supersede warnings in the memory inspectorPossibly taken @Sinchanak-212 claimed this today. Openarea: ux good first issue priority: medium
Difficulty 2/5 1-3 hours Newbie friendliness 84/100