cluster_pilots.py shows a traceback for a bad --k and leaves outputs when --truth is invalid
Maintainers usually reply within 3 days
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 83/100
Research direction
Start with inference/cluster_pilots.py and the CLI tests in tests/test_cluster_pilots.py; compare invalid --k handling with the existing --truth-without---k usage error. Check that invalid truth input is rejected before any CSV is written. Done means bad input prints a one-line usage error with exit status 2 and failed runs leave no output files.
Written by the indexing model from the issue text.
Description
Describe the bug
Two behaviours of inference/cluster_pilots.py on the #225 branch. An out-of-range --k ends in a raw ValueError traceback. If --truth is invalid, the group and centre CSVs have already been written when the error is raised, so a failed run leaves half its outputs.
To Reproduce
- Run
generate_synthetic_pilots.py, thencompute_features.pyon its output. python inference/cluster_pilots.py --k 1prints a traceback endingValueError: k must be 2 to 5 for 15 pilots, got 1.- Repeat a row in
inference/Data/synthetic_pilot_tiers.csv, then runpython inference/cluster_pilots.py --k 3 --truth inference/Data/synthetic_pilot_tiers.csv.pilot_clusters.csvandgroup_centres.csvare written, thenValueError: Pilot(s) repeated in truth: P01.
Expected behavior
A one-line usage error and exit status 2 for a bad --k, as --truth without --k already gives. No output files when the run fails.
Screenshots
Not applicable.
Additional context
Fit and score first, then write; use parser.error for input errors. Needs CLI tests in tests/test_cluster_pilots.py.
- Dominant language
- Python
- Stars
- 4
- Forks
- 9
- Avg merge
- 4d 17h
- Merged PRs (30d)
- 7
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from oss-slu/PilotDataSynchronization
-
area:docs area:xplane-plugin documentation needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
oss-slu/PilotDataSynchronization#259 ·
Maintainers usually reply within 3 days
-
Connect TCP with an invalid address is silent in the event logPossibly taken @PRINCEKK122 claimed this 22 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
oss-slu/PilotDataSynchronization#241 ·
Maintainers usually reply within 3 days
-
Document running the Python listener on a second PCPossibly taken @Omanhene20 claimed this 3 days ago. Openarea:docs area:ml area:relay documentation needs-triage
Difficulty 3/5 1-2 days Newbie friendliness 70/100
oss-slu/PilotDataSynchronization#264 · 1 assignee ·
Maintainers usually reply within 3 days
-
data_logger stops with a traceback if its CSV is open in ExcelPossibly taken @jmacd867 claimed this 10 days ago. Openarea:ml bug needs-triage python
oss-slu/PilotDataSynchronization#263 · 1 assignee ·
Maintainers usually reply within 3 days
-
baton_debug.log logs every sample, even with nothing connected, and grows without limitPossibly taken @Omanhene20 claimed this 3 days ago. Openarea:xplane-plugin enhancement needs-triage rust
Difficulty 4/5 3-5 days Newbie friendliness 56/100
oss-slu/PilotDataSynchronization#262 · 1 assignee ·
Maintainers usually reply within 3 days
All issues in oss-slu/PilotDataSynchronization
Similar issues
-
`destroy` sans terminal répond « Aborted. » au lieu de réclamer `--yes` comme `clean` et `reset`Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
stephrobert/dsoxlab#354 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
jasonacox/pypowerwall#472 ·
Maintainers usually reply within 1 day
-
[Bug]: DoubleMLRDDData accepts a score_col that is no data column (as in its docstring example); the running variable then becomes a covariate and RDFlex failsPossibly taken @vrjdev claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
DoubleML/doubleml-for-py#455 ·
Maintainers usually reply within 1 day
-
[Bug]: Python mod.Box[T] annotation gets a false generic_arg edge that replaces the parameter_type one ('is' on tree-sitter nodes)Possibly taken @rohit-jsfreaky claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Graphify-Labs/graphify#5110 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
assafelovic/gpt-researcher#2277 ·
Maintainers usually reply within 10 days