vnstat2: missing keep.d-file
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- build-system
Research direction
Start from the package Makefile under utils/vnstat2/ (the Package/vnstat2/conffiles block quoted in the report) and look at how sibling packages install a keep.d file from $(Package/.../install). Add /lib/upgrade/keep.d/vnstat2 listing /etc/vnstat.conf, then rebuild the package and check the generated file appears in the ipk/apk contents. Done means sysupgrade/config-backup keeps /etc/vnstat.conf.
Written by the indexing model from the issue text.
Description
Package Name
vnstat2
Maintainer
Jan Hoffmann [email protected]
OpenWrt Version
25.12.6 possibly also older versions
OpenWrt Target/Subtarget
various
Steps to Reproduce
Install package with apk.
Inside Makefile "Package/vnstat2/conffiles" correctly define "/etc/vnstat.conf" and "/etc/config/vnstat".
but /lib/upgrade/keep.d/vnstat2 is missing/never created.
Fortunately, /etc/config/vnstat is backed up via keep.d/base-files, but /etc/vnstat.conf is not.
So during sysupgrade or config-backup "/etc/vnstat.conf" never saved.
Actual Behaviour
look at "Steps to Reproduce"
Confirmation Checklist
- The package is maintained in this repository.
- I understand that issues related to the base OpenWrt repository or LuCI repository will be closed.
- I am reporting an issue for OpenWrt, not an unsupported fork.
- Dominant language
- Makefile
- Stars
- 4.7k
- Forks
- 4k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 251
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from openwrt/packages
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
openwrt/packages#31307 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 88/100
openwrt/packages#31306 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 Under an hour Newbie friendliness 65/100
openwrt/packages#31291 · 9 comments ·
Maintainers usually reply within 1 day
All issues in openwrt/packages
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
echemdb/svgdigitizer#330 ·
Maintainers usually reply within 1 day
-
bug good first issue severity: low
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
TMHSDigital/Awesome-Ads#37 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 Under an hour Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
`remix-hook-form/middleware` imports `unstable_createContext`, breaking on `react-router` >= 7.9.0Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
code-forge-io/remix-hook-form#189 ·