vnstat2: missing keep.d-file

Open Beginner friendly
#31,310 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Domain
build-system

Research direction

Start from the package Makefile under utils/vnstat2/ (the Package/vnstat2/conffiles block quoted in the report) and look at how sibling packages install a keep.d file from $(Package/.../install). Add /lib/upgrade/keep.d/vnstat2 listing /etc/vnstat.conf, then rebuild the package and check the generated file appears in the ipk/apk contents. Done means sysupgrade/config-backup keeps /etc/vnstat.conf.

Written by the indexing model from the issue text.

Description

bug
Package Name

vnstat2

Maintainer

Jan Hoffmann [email protected]

OpenWrt Version

25.12.6 possibly also older versions

OpenWrt Target/Subtarget

various

Steps to Reproduce

Install package with apk.
Inside Makefile "Package/vnstat2/conffiles" correctly define "/etc/vnstat.conf" and "/etc/config/vnstat".
but /lib/upgrade/keep.d/vnstat2 is missing/never created.
Fortunately, /etc/config/vnstat is backed up via keep.d/base-files, but /etc/vnstat.conf is not.
So during sysupgrade or config-backup "/etc/vnstat.conf" never saved.

Actual Behaviour

look at "Steps to Reproduce"

Confirmation Checklist
Dominant language
Makefile
Stars
4.7k
Forks
4k
Avg merge
2d 2h
Merged PRs (30d)
251

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openwrt/packages

All issues in openwrt/packages

Similar issues

More Build System issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.