logrotate: missing entry in keep.d-file

Open Beginner friendly
#31,306 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
88/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
linux
Domain
release

Research direction

Start from the logrotate package Makefile and compare its Package/logrotate/conffiles entry with the packaged /lib/upgrade/keep.d/logrotate file. The issue already identifies the mismatch: keep.d lists /etc/logrotate.d but omits /etc/logrotate.conf. Done means the keep.d entry matches the conffiles list so sysupgrade and config-backup retain /etc/logrotate.conf.

Written by the indexing model from the issue text.

Description

bug
Package Name

logrotate

Maintainer

Christian Beier [email protected]

OpenWrt Version

25.12.6 possibly also older versions

OpenWrt Target/Subtarget

various

Steps to Reproduce

Install package with apk.
Inside Makefile "Package/logrotate/conffiles" correctly define "/etc/logrotate.conf" and "/etc/logrotate.d/".
but /lib/upgrade/keep.d/logrotate only define "/etc/logrotate.d"
So during sysupgrade or config-backup "/etc/logrotate.conf" never saved

Actual Behaviour

look at "Steps to Reproduce"

Confirmation Checklist
Dominant language
Makefile
Stars
4.7k
Forks
4k
Avg merge
2d 2h
Merged PRs (30d)
251

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openwrt/packages

All issues in openwrt/packages

Similar issues

More Release issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.