Stack overflow during NPC-portal loading screens

Open
#3,684 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript
Domain
frontend, game-dev

Research direction

Start from follow-up #3426, then reproduce an NPC-portal loading screen with pause-on-exceptions enabled. Inspect the .push( ...array ) spreads in runtime/renderer/characters/characters.ts at lines 1156, 1686, 2466, 2886 and 3147, and verify whether any array exceeds V8's argument limit or whether another function is recursing. Done means the recursing function is identified, the root cause is confirmed, and a tested fix is in place.

Written by the indexing model from the issue text.

Description

area: client bug priority: high

Follow-up from #3426

The actual cause of the "Maximum call stack size exceeded" errors during NPC-portal loading screens is not yet identified. Candidates (unverified): the .push( ...array ) spreads in runtime/renderer/characters/characters.ts (lines 1156, 1686, 2466, 2886, 3147). A spread past V8's argument limit (~120k) throws exactly this RangeError.

Done when

  • The recursing function is identified via pause-on-exceptions during NPC teleport loading
  • Root cause is confirmed (spread overflow vs other recursion)
  • Fix is implemented and tested
Dominant language
Go
Stars
97
Forks
61
Avg merge
4h 14m
Merged PRs (30d)
913

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from opensro-dev/opensro

All issues in opensro-dev/opensro

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.