Stack overflow during NPC-portal loading screens
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
Research direction
Start from follow-up #3426, then reproduce an NPC-portal loading screen with pause-on-exceptions enabled. Inspect the .push( ...array ) spreads in runtime/renderer/characters/characters.ts at lines 1156, 1686, 2466, 2886 and 3147, and verify whether any array exceeds V8's argument limit or whether another function is recursing. Done means the recursing function is identified, the root cause is confirmed, and a tested fix is in place.
Written by the indexing model from the issue text.
Description
Follow-up from #3426
The actual cause of the "Maximum call stack size exceeded" errors during NPC-portal loading screens is not yet identified. Candidates (unverified): the .push( ...array ) spreads in runtime/renderer/characters/characters.ts (lines 1156, 1686, 2466, 2886, 3147). A spread past V8's argument limit (~120k) throws exactly this RangeError.
Done when
- The recursing function is identified via pause-on-exceptions during NPC teleport loading
- Root cause is confirmed (spread overflow vs other recursion)
- Fix is implemented and tested
- Dominant language
- Go
- Stars
- 97
- Forks
- 61
- Avg merge
- 4h 14m
- Merged PRs (30d)
- 913
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from opensro-dev/opensro
-
area: client enhancement priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
opensro-dev/opensro#3681 ·
Maintainers usually reply within 1 day
-
area: client bug priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
opensro-dev/opensro#3228 · 1 comment ·
Maintainers usually reply within 1 day
-
Format one minified client file with dprint (ongoing: one file per PR)Possibly taken A pull request linked to this issue is open or already merged. Openarea: client enhancement good first issue priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
opensro-dev/opensro#1 · 1 comment ·
Maintainers usually reply within 1 day
-
area: server bug priority: medium
Difficulty 3/5 Half a day Newbie friendliness 55/100
opensro-dev/opensro#3687 ·
Maintainers usually reply within 1 day
-
area: ops bug priority: high
Difficulty 4/5 3-5 days Newbie friendliness 32/100
opensro-dev/opensro#3685 ·
Maintainers usually reply within 1 day
All issues in opensro-dev/opensro
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
unbound-force/gaze#353 ·
Maintainers usually reply within 1 day
-
bug cross-seed ready-for-human
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
OneBusAway/maglev#2102 ·
Maintainers usually reply within 2 days
-
affects-8.5 component/session severity/moderate sig/transaction type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Waiting start: the fixed 503 body says another instance holds the lease when that may not be soOpen
Difficulty 1/5 Under an hour Newbie friendliness 70/100
Judgment-Pack/judgment-pack-gateway#474 ·
Maintainers usually reply within 1 day