feat(client): the guide's hunting grounds on dungeon pages (Donwhang, tomb)

Open
#3,395 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript
Domain
frontend, game-dev

Research direction

Start in cave-map.ts, where the cave floor frame is defined, and compare it with the world page's guide overlay that already tints a picked monster's hunting ground. Map each v1.696 dungeon page's origin, tile size and sectors per tile onto that frame, then check the result against the sub_e75d50 placement rule given in the issue. Done means a picked Donwhang or tomb monster's masks and icon draw on the cave floor in 0x80e9c624, and a test pins one Donwhang and one tomb ground to their known positions.

Written by the indexing model from the issue text.

Description

area: client enhancement priority: high

Follow-up from #3390 (PR #3381).

The guide overlay tints a picked monster's hunting ground on the world page (field). Monster rows on the later client's dungeon pages (dunhuang1-4, jinsi1-6; their region tiles are published as masks too) only open the matching floor of our cave map today. They draw no tint and no icon, because our cave pages are the v1.188 Dungeonmap images and their pixel frame differs from v1.696's map_manager pages. dunhuang uses 256 px tiles at 1 sector per tile, origin 127x128; jinsi1 uses 128 px, origin 125x132; and so on.

Done when:

  • Each v1.696 dungeon page's origin, tile size and sectors per tile are mapped onto our cave page's frame (cave-map.ts), checked against the BN placement rule (sub_e75d50: x = ((sx - ox) / perTile) * tileW, y = ((oy - sy) / perTile) * tileH).
  • A picked dungeon monster's masks and icon draw on the cave floor, tinted 0x80e9c624, the same as the world page.
  • A test pins one Donwhang and one tomb ground against their known positions.
Dominant language
Go
Stars
97
Forks
61
Avg merge
4h 14m
Merged PRs (30d)
913

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from opensro-dev/opensro

All issues in opensro-dev/opensro

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.