feat(client): the guide's hunting grounds on dungeon pages (Donwhang, tomb)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 30/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
Research direction
Start in cave-map.ts, where the cave floor frame is defined, and compare it with the world page's guide overlay that already tints a picked monster's hunting ground. Map each v1.696 dungeon page's origin, tile size and sectors per tile onto that frame, then check the result against the sub_e75d50 placement rule given in the issue. Done means a picked Donwhang or tomb monster's masks and icon draw on the cave floor in 0x80e9c624, and a test pins one Donwhang and one tomb ground to their known positions.
Written by the indexing model from the issue text.
Description
Follow-up from #3390 (PR #3381).
The guide overlay tints a picked monster's hunting ground on the world page (field). Monster rows on the later client's dungeon pages (dunhuang1-4, jinsi1-6; their region tiles are published as masks too) only open the matching floor of our cave map today. They draw no tint and no icon, because our cave pages are the v1.188 Dungeonmap images and their pixel frame differs from v1.696's map_manager pages. dunhuang uses 256 px tiles at 1 sector per tile, origin 127x128; jinsi1 uses 128 px, origin 125x132; and so on.
Done when:
- Each v1.696 dungeon page's origin, tile size and sectors per tile are mapped onto our cave page's frame (
cave-map.ts), checked against the BN placement rule (sub_e75d50: x = ((sx - ox) / perTile) * tileW, y = ((oy - sy) / perTile) * tileH). - A picked dungeon monster's masks and icon draw on the cave floor, tinted 0x80e9c624, the same as the world page.
- A test pins one Donwhang and one tomb ground against their known positions.
- Dominant language
- Go
- Stars
- 97
- Forks
- 61
- Avg merge
- 4h 14m
- Merged PRs (30d)
- 913
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from opensro-dev/opensro
-
area: client enhancement priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
opensro-dev/opensro#3681 ·
Maintainers usually reply within 1 day
-
area: client bug priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
opensro-dev/opensro#3228 · 1 comment ·
Maintainers usually reply within 1 day
-
Format one minified client file with dprint (ongoing: one file per PR)Possibly taken A pull request linked to this issue is open or already merged. Openarea: client enhancement good first issue priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
opensro-dev/opensro#1 · 1 comment ·
Maintainers usually reply within 1 day
-
area: server bug priority: medium
Difficulty 3/5 Half a day Newbie friendliness 55/100
opensro-dev/opensro#3687 ·
Maintainers usually reply within 1 day
-
area: ops bug priority: high
Difficulty 4/5 3-5 days Newbie friendliness 32/100
opensro-dev/opensro#3685 ·
Maintainers usually reply within 1 day
All issues in opensro-dev/opensro
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
unbound-force/gaze#353 ·
Maintainers usually reply within 1 day
-
bug cross-seed ready-for-human
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
OneBusAway/maglev#2102 ·
Maintainers usually reply within 2 days
-
affects-8.5 component/session severity/moderate sig/transaction type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Waiting start: the fixed 503 body says another instance holds the lease when that may not be soOpen
Difficulty 1/5 Under an hour Newbie friendliness 70/100
Judgment-Pack/judgment-pack-gateway#474 ·
Maintainers usually reply within 1 day