Move thinning to occur after fitting the Stan model

Open
#491 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@AKlebus is already working on this.

Since Jun 18, 2025.

  • #505 by @AKlebus — open

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
r
Domain
data

Research direction

Start by locating where rbmi fits the Stan model and currently passes Stan's thinning option. Read how the retained Stan object is used for rbmi inference, then separate full-model fitting from the later sample thinning step. Done means inference can use all fitted samples while rbmi applies thinning afterward to address autocorrelation.

Written by the indexing model from the issue text.

Description

enhancement good first issue

Use case that has come up is one where you wish to do inference on the complete set of samples where auto correlation is not (or less?) of an issue but then apply thinning to the samples used by rbmi to remove said autocorrelation.

At the moment we just uses Stans inbuilt thinning so this could be implemented simply by manually applying the thinning after fitting the full Stan model (as the retained Stan object would contain the full set of samples).

Dominant language
R
Stars
21
Forks
13
Avg merge
13h 22m
Merged PRs (30d)
7

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openpharma/rbmi

All issues in openpharma/rbmi

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.