Allow Course Editors to save ORA and Teams settings in Pages & Resources

Open
  • Is something wrong?
#596 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
python, typescript
Domain
authorization

Research direction

The issue names PageSettingButton.jsx and the ORA and Teams settings modals, and links a related route guard issue at openedx/openedx-authz#286. Read the existing permission checks in the modal and backend paths, then decide whether these settings require advanced-settings permission or also allow Course Editors. Done means all four apps have consistent UI and backend permissions, a Course Editor cannot be offered a failing save, and tests cover the behavior.

Written by the indexing model from the issue text.

Description

willow
Description

Some settings are split between Advanced Settings and Pages & Resources. The ORA and Teams settings modals in Pages & Resources only validate the advanced_settings permission, so a Course Editor cannot save them even though they can open Pages & Resources.

Current Behavior

A Course Editor changes ORA or Teams settings in Pages & Resources and saving fails. The frontend already disables the gear button for Progress and Wiki:

// PageSettingButton.jsx:54
const isGearDisabled = (id === 'progress' || id === 'wiki') && !canManageAdvancedSettings;

That does not cover the deep link to the modal (see the related route-guard issue).

Expected Behavior

For ORA, Teams, Progress and Wiki, the UI and the backend agree on which permission is required, and an Editor is never offered a save that is guaranteed to fail.

Steps to reproduce
  1. Log in as a Course Editor.
  2. Open Pages & Resources and open the Teams (or ORA) settings.
  3. Change a setting and save.
  4. Observe that the save fails.
Acceptance Criteria
  • A decision is made on which permission governs ORA, Teams, Progress and Wiki settings (advanced settings only, or both).
  • If advanced-settings-only: the controls are disabled in the modal itself, not only in the gear button, so deep links are covered.
  • If both are accepted: the backend allows either permission for these four apps.
  • A Course Editor either saves successfully or sees the controls disabled, never a failing save.
  • Tests are added or updated.
Proposed Solution

Pick one of:

  • Disable the controls directly in the modals for the four apps.
  • Accept both permissions on the backend for the four apps.
Related Issues

Related to openedx/openedx-authz#286 (route guard finding).

Dominant language
Python
Stars
0
Forks
10
Avg merge
3d 23h
Merged PRs (30d)
21

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openedx/openedx-authz

All issues in openedx/openedx-authz

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.