Allow Course Editors to save ORA and Teams settings in Pages & Resources

Abierto
  • ¿Algo no está bien?
#596 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
55/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python, typescript
Área
authorization

Línea de trabajo

The issue names PageSettingButton.jsx and the ORA and Teams settings modals, and links a related route guard issue at openedx/openedx-authz#286. Read the existing permission checks in the modal and backend paths, then decide whether these settings require advanced-settings permission or also allow Course Editors. Done means all four apps have consistent UI and backend permissions, a Course Editor cannot be offered a failing save, and tests cover the behavior.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

willow
Description

Some settings are split between Advanced Settings and Pages & Resources. The ORA and Teams settings modals in Pages & Resources only validate the advanced_settings permission, so a Course Editor cannot save them even though they can open Pages & Resources.

Current Behavior

A Course Editor changes ORA or Teams settings in Pages & Resources and saving fails. The frontend already disables the gear button for Progress and Wiki:

// PageSettingButton.jsx:54
const isGearDisabled = (id === 'progress' || id === 'wiki') && !canManageAdvancedSettings;

That does not cover the deep link to the modal (see the related route-guard issue).

Expected Behavior

For ORA, Teams, Progress and Wiki, the UI and the backend agree on which permission is required, and an Editor is never offered a save that is guaranteed to fail.

Steps to reproduce
  1. Log in as a Course Editor.
  2. Open Pages & Resources and open the Teams (or ORA) settings.
  3. Change a setting and save.
  4. Observe that the save fails.
Acceptance Criteria
  • A decision is made on which permission governs ORA, Teams, Progress and Wiki settings (advanced settings only, or both).
  • If advanced-settings-only: the controls are disabled in the modal itself, not only in the gear button, so deep links are covered.
  • If both are accepted: the backend allows either permission for these four apps.
  • A Course Editor either saves successfully or sees the controls disabled, never a failing save.
  • Tests are added or updated.
Proposed Solution

Pick one of:

  • Disable the controls directly in the modals for the four apps.
  • Accept both permissions on the backend for the four apps.
Related Issues

Related to openedx/openedx-authz#286 (route guard finding).

Lenguaje dominante
Python
Estrellas
0
Forks
10
Merge medio
3 d 23 h
PR fusionados (30 d)
21

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de openedx/openedx-authz

Todos los issues de openedx/openedx-authz

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.