Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Failed QR wait puts the pairing image in selectable text

Open
  • Is something wrong?
#1,755 1 comment 1 reaction 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
desktop

Research direction

Start with the diagnostic path: ShowDiagnostic builds the text, and ChannelLinkDiagnosticText.Format is where the QR data URL must be omitted from a failed web.login.wait result. Run ChannelLinkDiagnosticTextTests, especially Format_OmitsTheQrImageFromAFailedWait and Format_RedactsTheImageBeforeTheResponseIsTrimmed. Done means both pass and the image payload no longer appears in the selectable diagnostic text, while the picture rendered by RenderQrAsync is unchanged.

Written by the indexing model from the issue text.

Description

clawsweeper:needs-security-review clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:security issue-rating: 🦞 diamond lobster P2

What Problem

Show QR stores the gateway pairing image. If web.login.wait then fails, the Channels diagnostic serializes that data URL into a text block with selection enabled. The pairing image can be copied as text, not only scanned from the picture.

Why

The wait parameters include currentQrDataUrl, and the diagnostic prints those parameters plus the raw response. A failed wait therefore puts the image payload in selectable text.

User Impact

A failed QR wait still shows the method, the channel, the timeout, and the error. The image payload is replaced with <omitted>. The picture itself is unchanged, and a start call that has no image is unchanged.

Evidence

ChannelLinkDiagnosticTextTests.Format_OmitsTheQrImageFromAFailedWait feeds the data URL in the wait parameters, the error, and the raw response. The payload is absent. Format_RedactsTheImageBeforeTheResponseIsTrimmed uses an image longer than the 1000 character response cap, so the start of the payload cannot survive the trim. The page contract failed while ShowDiagnostic still joined the raw text, then passed after it assigned ChannelLinkDiagnosticText.Format.

Real behavior proof

The selectable text is that formatted string. The Channels page was not opened. The picture path is the same RenderQrAsync call as before.

Validation

./build.ps1 passed. Shared tests: 4318 passed, 34 skipped. Tray tests: the first full run passed 4083 and failed QueuedSend_InFlightAckWithoutLifecycle_RequeuesAndRetriesSameIdempotencyKey with message q2 still Sending. That test passed alone. The full Tray rerun passed 4084, with 0 skipped.

Compare: https://github.com/openclaw/openclaw-windows-node/compare/main...SebTardif:fix/f088-omit-qr-from-diagnostic?expand=1

Dominant language
C#
Stars
2.1k
Forks
315
Avg merge
2d 7h
Merged PRs (30d)
135

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openclaw/openclaw-windows-node

All issues in openclaw/openclaw-windows-node

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.