fix(connection): reject bad SSH forward ports before connect
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 20/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- csharp, powershell
- Domain
- desktop, networking
Research direction
The change is already on the branch SebTardif:fix/f068-reject-bad-forward-ports, so the work is review, not coding. Read SshForwardPorts.TryParse and its two call sites, Connection Status and the connection page, and confirm a bad port returns before ConnectAsync. Done means blank, unparsed and out-of-range ports are rejected, and ./build.ps1 passes.
Written by the indexing model from the issue text.
Description
CreatePullRequest is forbidden for this account, so this is the write-up for the branch.
Branch: SebTardif:fix/f068-reject-bad-forward-ports
Head: fe0c60aa5771a571dd1144abc206bd0e293da88c
Connection Status accepted a blank SSH forward port as 18789 or 18790, and it kept a value such as 70000. Connect could then start the tunnel. The connection page already rejected those values.
SshForwardPorts.TryParse rejects a blank, unparsed, or out-of-range remote or local port. Both Connection Status and the connection page use it, and a bad port returns before ConnectAsync.
./build.ps1 passed. Shared 4263 passed, 34 skipped, 4297 total. Tray 4004 passed.
The Connection Status window was not opened on this head, and ssh.exe was not started.
Ref F068.
- Dominant language
- C#
- Stars
- 2.1k
- Forks
- 315
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 135
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from openclaw/openclaw-windows-node
-
clawsweeper:source-repro impact:ux-release-blocker issue-rating: 🦞 diamond lobster P0
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
openclaw/openclaw-windows-node#1723 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:security issue-rating: 🦞 diamond lobster P2
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
openclaw/openclaw-windows-node#1516 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
clawsweeper:needs-info clawsweeper:needs-maintainer-review clawsweeper:no-new-fix-pr impact:ux-friction issue-rating: 🦐 gold shrimp P1 stale
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
openclaw/openclaw-windows-node#1145 · 5 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
clawsweeper:needs-security-review clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:security issue-rating: 🦞 diamond lobster P2
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
openclaw/openclaw-windows-node#1755 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
bug impact:ux-friction issue-rating: 🦪 silver shellfish P2
Difficulty 3/5 Half a day Newbie friendliness 50/100
openclaw/openclaw-windows-node#1753 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
All issues in openclaw/openclaw-windows-node
Similar issues
-
area: design documentation
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
eyalgolan/statecraft-israel#883 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 3 days
-
area/indexing bug package/core triage
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
enhancement needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
elastic/docs-builder#4495 ·
Maintainers usually reply within 1 day
-
StreamProtoReader pool state corruption after interrupted deserializationPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
protobuf-net/protobuf-net#1375 · 2 comments ·
Maintainers usually reply within 2 days