Are negative scale values allowed? (schema says > 0, prose says non-zero)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 52/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- python
- Domain
- data, documentation
Research direction
Read the coordinate transformations schema lines 192–197 and the prose in index.md lines 836–837, then review the two issue comments for the intended meaning of scale. Decide whether negative values are valid and align the schema and prose accordingly. Done when both sources state the same rule for scale values.
Written by the indexing model from the issue text.
Description
Describe the issue
just wanted to clarify the intent for scale values in 0.6.
The schema requires every value to be strictly positive (coordinate_transformations.schema#L192-L197):
"items": {"type": "number", "exclusiveMinimum": 0}
but the prose only says:
https://github.com/ome/ngff-spec/blob/89da1da5b0491f83b7cdde7d123aef763a457029/index.md#L836-L837
which (to me) reads as allowing negative values (i.e. axis flips), since those are invertible too. (The 0.5 schema had no constraint on the values at all.)
Are negative scales meant to be valid in 0.6? If so, I guess the schema should be "not": {"const": 0} (or unconstrained, since the prose only says SHOULD)... and if not, the prose should probably say "MUST be greater than zero".
(fwiw, at least one implementation has already started writing flips as affine just to satisfy the schema: neuroscales/brainhops#433)
- Dominant language
- Python
- Stars
- 180
- Forks
- 81
- Avg merge
- 5d 7h
- Merged PRs (30d)
- 9
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ome/ngff
-
feature request
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
leftover mention of `path` in v0.6 scale/translation transforms?Possibly taken @tlambert03 claimed this 1 day ago. Open0.6 post-release patch bug
Difficulty 1/5 Under an hour Newbie friendliness 72/100
ome/ngff#661 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
0.6 post-release patch bug
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
Maintainers usually reply within 1 day
-
should byDimension inputAxes/outputAxes be "integer" in the schemaPossibly taken @tlambert03 claimed this 1 day ago. Open0.6 post-release patch bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
0.6 post-release patch
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ome/ngff#634 · 1 reaction · 1 assignee ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
comp/desktop P3 type/feature
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
NousResearch/hermes-agent#154285 ·
Maintainers usually reply within 1 day
-
docs: qualify copied and custom kubectl debug policy notesPossibly taken @nym01 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
kubescape/cel-admission-library#166 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
SACGF/variantgrid#2804 · 1 comment ·
Maintainers usually reply within 1 day
-
[BUG] HTTP lifecycle dispatch treats a NO_PROXY-only environment as corporate egress and skips the resolve-and-pinned sessionPossibly taken @bodapatisaikrishna claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day