[tests]: Set modules in all plot_* calls within test functions
Maintainers usually reply within 1 day
@Schiano-NOAA is already working on this.
Since Oct 13, 2026.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
Research direction
The payload does not name the test files, so start by running the test suite locally and noting where the interactive module prompt appears, then find the plot_* calls in the test functions that omit the module argument. Add a valid module value to each of those calls; the issue leaves the choice of value open, so check how the plotting functions use it. Done means the suite runs without any prompt, and an optional filter_data test covers the user-selection path.
Written by the indexing model from the issue text.
Description
Presently, all tests of the plotting function omit the module parameter, which eventually prompts the user to select a module via the R terminal. This makes running the tests suite locally not automatic (the user has to continuously interact with the tests by selecting modules). It would probably be more efficient to set the module parameter in each call to a plot_* function within the testing suite, rather than leaving it to wait for a user prompt.
An additional test could be created specifically for filter_data that tests that the user selection works, if there are concerns about that functionality breaking.
- Dominant language
- R
- Stars
- 20
- Forks
- 9
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 12
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nmfs-ost/stockplotr
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
nmfs-ost/stockplotr#422 ·
Maintainers usually reply within 1 day
-
[fix]: module name selection retained in environment when `make_rda = T`Possibly taken @sbreitbart-NOAA claimed this 3 days ago. Openbug
nmfs-ost/stockplotr#421 · 5 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
Make tests more efficientPossibly taken @JZahner1 claimed this 3 days ago. Open
nmfs-ost/stockplotr#420 · 4 comments · 2 assignees ·
Maintainers usually reply within 1 day
-
[tests]: are "rda file made when indicated" tests needed for every plot?Possibly taken @Schiano-NOAA claimed this 4 days ago. Openquestion
nmfs-ost/stockplotr#418 · 10 comments · 3 assignees ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 40/100
nmfs-ost/stockplotr#415 ·
Maintainers usually reply within 1 day
All issues in nmfs-ost/stockplotr
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
HelenaLC/spatialdataR#284 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 71/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 71/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Hackathon: Tier 1
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
pharmaverse/logrx#309 ·