feat: move every native button onto the shared Button

Open
#780 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
32/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
html, rust

Research direction

Start from the tracking issue #776 and the shared Button from the blocking issue discussed there; nothing here can land before it. Then inventory every raw <button> the pages draw (action rows, Sign out, dialogs, the pause control, table row actions) and replace each with the shared component page by page. Done means before/after screenshots per page, a §4.5 contract row, a gallery entry, axe-core and ARIA snapshot rows, and the §13.7.5 keyboard-only scenarios, with the WebKit job's header.feature:53 dark example passing.

Written by the indexing model from the issue text.

Description

accessibility enhancement

Part of #776.

Every <button> the pages draw today (action rows, Sign out, dialogs, the pause control, table row actions) uses Button, with before/after screenshots of each page.

Needs first: Button (see "blocked by").

Its own pull request: it changes every page. Closes #775 once the WebKit job's header.feature:53 dark example passes.

Acceptance: Meets the bar in the tracking issue: WCAG 2.2 AA in full when it merges, a contract row in §4.5, and every step of §13.7.5 (component, gallery entry, axe-core and ARIA snapshot rows, keyboard-only contract scenarios).

Dominant language
Rust
Stars
0
Forks
0
Avg merge
56m
Merged PRs (30d)
349

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nledford/Ladderback

All issues in nledford/Ladderback

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.