test: a launchd removal test can refuse the bootout instead of the check after it
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
Research direction
Start in crates/adapters/platform/src/service/tests.rs at a_removal_whose_check_on_the_stopping_agent_fails_keeps_the_file_and_says_so, and run it alone with cargo nextest run to see the fake harness in action. Read how the fake records a command versus when it decides that command's answer; the test polls every 10 ms for the recorded bootout before arming the refusal. Move the arming so it only affects commands after the bootout (for example, on the bootout's completion), then rerun the test repeatedly to confirm the refusal can no longer land on the bootout itself.
Written by the indexing model from the issue text.
Description
platform service::tests::a_removal_whose_check_on_the_stopping_agent_fails_keeps_the_file_and_says_so (crates/adapters/platform/src/service/tests.rs) failed once in a full cargo nextest run --workspace on a loaded machine:
left: ManagerRefused { command: "launchctl bootout …", said: "Could not talk to launchd" }
It expects the refusal on the later launchctl print check. Run alone it passed 5 of 5 times, on main and on a branch, and the full rerun passed.
Likely cause [inference]: the test polls every 10 ms for a recorded bootout command, then makes the fake refuse. If the fake records a command before it decides that command's answer, a poll that lands between the two makes the refusal hit the bootout itself. Under load the window is wide enough to hit.
Fix direction: make the refusal apply only to commands after the bootout (for example, the fake refuses from the next command on, or the test arms the refusal on the bootout's completion rather than its recording), so the test can't depend on timing. Test-only.
- Dominant language
- Rust
- Stars
- 0
- Forks
- 0
- Avg merge
- 56m
- Merged PRs (30d)
- 349
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nledford/Ladderback
-
bug priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
nledford/Ladderback#809 ·
Maintainers usually reply within 1 day
-
enhancement priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nledford/Ladderback#746 ·
Maintainers usually reply within 1 day
-
enhancement priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
nledford/Ladderback#745 ·
Maintainers usually reply within 1 day
-
bug priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
nledford/Ladderback#647 ·
Maintainers usually reply within 1 day
-
bug priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
nledford/Ladderback#637 · 1 comment ·
Maintainers usually reply within 1 day
All issues in nledford/Ladderback
Similar issues
-
benchmark-review
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
Maintainers usually reply within 1 day
-
area:filesystem bug need-triage
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Captions panel does not offer to show an existing transcriptPossibly taken @thedavidweng claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
CapSoftware/Cap#4276 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
libracoder/kiri#364 ·
Maintainers usually reply within 1 day