WebKit: the header's failed sign-out message fails color contrast at 320 pixels, 200 percent text, dark colors

Open
#775 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
rust

Research direction

Start by running just test-ui webkit --name "A sign-out that reaches no daemon" and capturing axe-core's color-contrast node list (selectors, foreground/background colors, ratios). Compare the 320 | 256 | 200 | dark colors row at features/ui/header.feature:53 with its light-colors sibling, and read the assertion at steps/start_page.ts:54. Run just test-contrast against the header tokens, and inspect the header component's dark-mode background for translucency or blending at 200 percent text. Done means the WebKit job passes on main with the scenario assertions unchanged, or documented evidence that axe-core misreads WebKit's background.

Written by the indexing model from the issue text.

Description

bug

What: since #770 (the header bar polish) merged, the UI journeys (WebKit, axe-core, keyboard) job fails one example on main: "A sign-out that reaches no daemon says so and leaves the header's height as it was, at 320 pixels with 200 percent text in dark colors" (features/ui/header.feature:53, the 320 | 256 | 200 | dark colors row). It failed the same way on #770's own head (a69a3b4e) before the merge, and on main at e838178b (run 43776114777, job 133003980200):

And the page has no accessibility violations # steps/start_page.ts:54
  + 'color-contrast: Elements must meet minimum color contrast ratio thresholds (4 nodes)'

The light-colors example of the same scenario passes in WebKit, and both examples pass in Chromium (a required check) and Firefox.

Why it matters: WCAG 2.2 AA contrast is an invariant of the shared component set (§4.5, A2). Four elements in WebKit, dark colors, 200 percent text, with the "sign-out reached no daemon" message showing, fall below the 4.5:1 (or 3:1 for large text) threshold axe-core checks. It may be a real contrast gap that only WebKit's rendering exposes, such as a translucent or blended background behind the message or the header's controls at that size, or axe-core computing the background differently under WebKit. Which one isn't known yet.

To do:

  • run just test-ui webkit --name "A sign-out that reaches no daemon" and print axe-core's node list for color-contrast (the selectors, the foreground and background colors and the ratio);
  • if the colors are really below the threshold, fix the tokens or the component (just test-contrast checks the tokens), and the scenario passes unchanged;
  • if axe-core misreads the background in WebKit only, say so with the evidence before changing anything in the test.

Acceptance: the example passes in the WebKit job on main, with no change to the scenario's assertions.

Dominant language
Rust
Stars
0
Forks
0
Avg merge
56m
Merged PRs (30d)
349

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nledford/Ladderback

All issues in nledford/Ladderback

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.