Say why a history is orphaned when its owner tags disagree

Open
#714 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
rust

Research direction

Start from where the orphaned listing is built: find the type/response that the orphaned groups are serialized into, and the place that currently emits the ui-orphaned-untagged message key, then follow it into the catalog that holds the message text. Read the domain code that produces OwnerTag::Disagree (#713, #286) to see what reason information is already available before adding the code to the API. Done means a disagreeing-tag snapshot is listed in its own group with its own message, distinct from snapshots that truly lack the tag, with a catalog entry and test coverage for both groups.

Written by the indexing model from the issue text.

Description

enhancement

Since #713, a snapshot whose ladderback-agent: or ladderback-plan: tags disagree is orphaned (#286). The orphaned group still says "This history lacks the tag of an agent or a plan" (ui-orphaned-untagged), which is wrong for these snapshots, and they share a group with snapshots that truly lack the tag.

Saying it properly needs the reason to reach the UI: the domain already knows it (OwnerTag::Disagree), but the orphaned listing's API carries no reason code. Add one, a catalog message for it, and separate groups for the two cases.

Low priority: nothing is deleted or kept wrongly; only the explanation is off.

Dominant language
Rust
Stars
0
Forks
0
Avg merge
56m
Merged PRs (30d)
349

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nledford/Ladderback

All issues in nledford/Ladderback

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.