[Bug] File action sheet shows no actions at all for locked files
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 86/100
Research direction
Start in FileActionsBottomSheet.handleState() and inspect how displayActions() and displayLockInfo() append rows to the sheet. The issue identifies the call order causing the actions to be skipped and suggests rendering actions before lock information. Done when a locked file shows its regular actions alongside the lock information; the payload names no test file.
Written by the indexing model from the issue text.
Description
Steps to reproduce
- Lock a file (e.g. open a document in the Text or OnlyOffice app, or use "Lock file" from another client).
- In the Android app, open the folder that contains the locked file.
- Tap the three-dot menu of that file.
Actual behaviour
The bottom sheet shows the file name and a "Locked by the app …" row, but no actions at all — not even edit, rename, download or delete. The sheet is short and cannot be expanded by dragging.
Expected behaviour
The regular action list is shown, plus the lock information row.
Cause
FileActionsBottomSheet.handleState() calls displayLockInfo() before displayActions():
if (state.lockInfo != null) {
displayLockInfo(state.lockInfo)
}
displayActions(state.titleFile, state.actions)
displayActions() starts with if (binding.fileActionsList.isNotEmpty()) return, so as soon as the lock row has been appended, every action is skipped. Only the lock row ends up in the sheet.
Suggested fix
Render the actions first and append the lock info afterwards:
displayActions(state.titleFile, state.actions)
if (state.lockInfo != null) {
displayLockInfo(state.lockInfo)
}
This is also what makes the unlock action reachable — see #17838.
Environment
- Nextcloud Android 35.0.1 (Play) and current master, Android 16, Pixel 9 Pro
- Server: Nextcloud 34 (AIO), files_lock 34.0.1
🤖 Generated with Claude Code
- Dominant language
- Kotlin
- Stars
- 5.6k
- Forks
- 2k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 92
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nextcloud/android
-
[Bug] Lock owned by another client (e.g. Text app) cannot be unlocked from the appPossibly taken @falkloewert claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Modification time is not preserved when uploading MediaStore content via Android sharePossibly taken @alperozturk96 claimed this 26 days ago. Open3. to review bug feature: transfers
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
nextcloud/android#17675 · 4 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
0. Needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
nextcloud/android#17533 · 1 comment ·
Maintainers usually reply within 1 day
-
RC 34.1.0-01: Duplicated wording in creation menu — "New" prefix + creator name produces "New New document" ("Neu Neues Dokument")Possibly taken @ChristianTannheimer claimed this 92 days ago. Open0. Needs triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
0. Needs triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
Maintainers usually reply within 1 day
All issues in nextcloud/android
Similar issues
-
area/kotlin
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
dafonton77-tech/Cadreenf#11 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Hy4ri/hermes-mobile#1647 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
rawnaldclark/Stash#649 ·
Maintainers usually reply within 1 day