when searching with last word autocompleted trailing space is not trimmed

Open Beginner friendly
#17,183 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
64/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
kotlin
Domain
mobile, search

Research direction

No source files or tests are named in the issue. Start at the Android app's search screen and trace how the submitted query reaches folder search, reproducing the failure with “files ”; done means trailing autocomplete spaces no longer prevent finding the “files” folder, with relevant search tests updated or added if present.

Written by the indexing model from the issue text.

Description

0. Needs triage bug
⚠️ Before posting ⚠️
  • This is a bug, not a question or an enhancement.
  • I've searched for similar issues and didn't find a duplicate.
  • I've written a clear and descriptive title for this issue, not just "Bug" or "Crash".
  • I agree to follow Nextcloud's Code of Conduct.
Steps to reproduce
  1. search for a folder (e.g "files"
  2. select some completion from the keyboard or (adding a space at the end after a word) (eg. "files ")
  3. search won't find it
Expected behaviour

The search trims trailing spaces (if not specified somehow explicitly) and the finds the something (in eg. the folder "files")

Actual behaviour

The folder "files" is not found, as it is searched for "files "

Android version

16

Device brand and model

Pixel 7a

Stock or custom OS?

Stock

Nextcloud android app version

34.0.0

Nextcloud server version

33.0.5

Using a reverse proxy?

I don't know

Android logs

No response

Server error logs

Additional information

This behaviour frustrates me as searching often returns nothing where it shouldn't.

I haven't considered files/folders actually ending on a space, they don't make sense to me that much and should be found none the less.

Dominant language
Kotlin
Stars
5.6k
Forks
2k
Avg merge
1d 21h
Merged PRs (30d)
101

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nextcloud/android

All issues in nextcloud/android

Similar issues

More Kotlin issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.