Decide header and row for an open parent whose subtasks are all complete

Open
  • Is something wrong?
#408 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
csharp, typescript
Domain
design, frontend

Research direction

Read TaskFlow.Web/src/lib/journal-rows.ts around buildJournalBlocks and the AC 4 wording in docs/FRONTEND.md. First decide the intended behavior for an open parent whose subtasks are all complete, checking the Tasks page rule referenced by #384. Then update the acceptance criteria and add a test for the chosen behavior.

Written by the indexing model from the issue text.

Description

question

Follow-up from #407 (feat(journal): apply the goal and work model to journal rows and remove isContextOnly (#387)), raised during UX testing.

Problem

An open parent whose subtasks are all completed shows twice on a journal day: as a normal row (with Mark done, Block and Remove) and as a header repeating its title above the completed subtasks ("1/1 subtasks complete").

Steps to reproduce:

  1. Plan a parent on today, then add one subtask planned on today. The parent becomes a header.
  2. Mark the subtask done and reload.
  3. The parent shows as a row, and a header with the same title still shows above the completed subtask.

#387 AC 4 covers this duplication only for a completed parent ("a completed parent with completed subtasks shows both its row and a header"). It does not say what an open parent with all-completed subtasks should show. buildJournalBlocks currently gives it the same row-plus-header treatment, and its doc comment says so ("Every parent with at least one subtask row of the day gets a header"). So this is a spec gap and not a regression. Severity: 🔵 Docs / UX decision.

Location

TaskFlow.Web/src/lib/journal-rows.ts:36 at a066163 (permalink)

Suggested approach

Decide the intended behaviour, then do one of:

  • Keep it. Add the open-parent case to the AC 4 wording in docs/FRONTEND.md, and cover it with a test.
  • Show the header only while a parent is completed or has an open subtask on the day. An open parent with all subtasks completed would then show just its row.

Deferred from #407 because it is a product decision about the rule shared with the Tasks page (#384), not a defect in that PR. I did not check how the Tasks page renders the same case.

Created by @nevridge with Claude Code during review of #407

Dominant language
C#
Stars
1
Forks
0
Avg merge
2h 2m
Merged PRs (30d)
98

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nevridge/TaskFlow

All issues in nevridge/TaskFlow

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.