Decide header and row for an open parent whose subtasks are all complete
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 1-2 天
- 新手友好度
- 35/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- csharp, typescript
调研方向
Read TaskFlow.Web/src/lib/journal-rows.ts around buildJournalBlocks and the AC 4 wording in docs/FRONTEND.md. First decide the intended behavior for an open parent whose subtasks are all complete, checking the Tasks page rule referenced by #384. Then update the acceptance criteria and add a test for the chosen behavior.
由索引模型根据 Issue 内容生成。
描述
Follow-up from #407 (feat(journal): apply the goal and work model to journal rows and remove isContextOnly (#387)), raised during UX testing.
Problem
An open parent whose subtasks are all completed shows twice on a journal day: as a normal row (with Mark done, Block and Remove) and as a header repeating its title above the completed subtasks ("1/1 subtasks complete").
Steps to reproduce:
- Plan a parent on today, then add one subtask planned on today. The parent becomes a header.
- Mark the subtask done and reload.
- The parent shows as a row, and a header with the same title still shows above the completed subtask.
#387 AC 4 covers this duplication only for a completed parent ("a completed parent with completed subtasks shows both its row and a header"). It does not say what an open parent with all-completed subtasks should show. buildJournalBlocks currently gives it the same row-plus-header treatment, and its doc comment says so ("Every parent with at least one subtask row of the day gets a header"). So this is a spec gap and not a regression. Severity: 🔵 Docs / UX decision.
Location
TaskFlow.Web/src/lib/journal-rows.ts:36 at a066163 (permalink)
Suggested approach
Decide the intended behaviour, then do one of:
- Keep it. Add the open-parent case to the AC 4 wording in
docs/FRONTEND.md, and cover it with a test. - Show the header only while a parent is completed or has an open subtask on the day. An open parent with all subtasks completed would then show just its row.
Deferred from #407 because it is a product decision about the rule shared with the Tasks page (#384), not a defect in that PR. I did not check how the Tasks page renders the same case.
Created by @nevridge with Claude Code during review of #407
- 主要语言
- C#
- 星标
- 1
- 派生
- 0
- 平均合并
- 2 小时 2 分钟
- 30 天内合并 PR
- 98
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
nevridge/TaskFlow 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 65/100
维护者通常 1 天内回复
-
tech-debt
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
查看 nevridge/TaskFlow 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 74/100
juandresrodca/AdminForge#54 ·
-
要トリアージ 辞書
难度 1/5 1-3 小时 新手友好度 86/100
yksr-melt/Meltype#1625 · 1 个 reaction ·
维护者通常 1 天内回复
-
Docs typo未关闭
难度 1/5 1 小时以内 新手友好度 78/100
MonoGame/docs.monogame.github.io#328 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
space-wizards/RobustToolbox#7197 ·
维护者通常 1 天内回复
-
documentation high priority
难度 2/5 1-3 小时 新手友好度 76/100
lachydotmcg/capri-desktop#201 ·
维护者通常 1 天内回复