Attribute PUT /JournalEntries todoTaskItemIds by the user's local date

Open
  • Is something wrong?
#406 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp, openapi
Domain
api, backend

Research direction

Start by grooming the issue, then inspect the PUT /JournalEntries/{id} handler, the other journal endpoints that accept a timezone offset, and the assistant's update_journal caller. Check how the web app calls this endpoint and update docs/API.md; done means the assistant sends the offset, the response uses the user's local date, and an integration test covers the change.

Written by the indexing model from the issue text.

Description

bug

Follow-up to #387. Part of #366.

Problem

PUT /JournalEntries/{id} attributes the todoTaskItemIds in its response by UTC date, not by the user's local date. Journal dates are the user's local dates, and carry-forward already uses the client's timezone offset with no UTC fallback, so near midnight the response can attribute tasks to the wrong day.

#387 leaves this as it is: the behaviour is documented, and nothing in the web app reads the field.

To decide in grooming

  • Add a timezone offset to the request and attribute by the user's local date, as the other journal endpoints do.
  • Check whether the assistant (update_journal) reads todoTaskItemIds. If it does, this is more urgent.
  • Check how the web app calls the endpoint, and update docs/API.md.

Notes

  • This changes the API contract, so the assistant has to send the offset. After the monorepo move (#397), so both ship in one PR and the integration test covers it.
  • Needs grooming first.
Dominant language
C#
Stars
1
Forks
0
Avg merge
2h 2m
Merged PRs (30d)
98

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nevridge/TaskFlow

All issues in nevridge/TaskFlow

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.