Attribute PUT /JournalEntries todoTaskItemIds by the user's local date

未关闭
  • 哪里不对？
#406 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
csharp, openapi
领域
api, backend

调研方向

Start by grooming the issue, then inspect the PUT /JournalEntries/{id} handler, the other journal endpoints that accept a timezone offset, and the assistant's update_journal caller. Check how the web app calls this endpoint and update docs/API.md; done means the assistant sends the offset, the response uses the user's local date, and an integration test covers the change.

由索引模型根据 Issue 内容生成。

描述

bug

Follow-up to #387. Part of #366.

Problem

PUT /JournalEntries/{id} attributes the todoTaskItemIds in its response by UTC date, not by the user's local date. Journal dates are the user's local dates, and carry-forward already uses the client's timezone offset with no UTC fallback, so near midnight the response can attribute tasks to the wrong day.

#387 leaves this as it is: the behaviour is documented, and nothing in the web app reads the field.

To decide in grooming

  • Add a timezone offset to the request and attribute by the user's local date, as the other journal endpoints do.
  • Check whether the assistant (update_journal) reads todoTaskItemIds. If it does, this is more urgent.
  • Check how the web app calls the endpoint, and update docs/API.md.

Notes

  • This changes the API contract, so the assistant has to send the offset. After the monorepo move (#397), so both ship in one PR and the integration test covers it.
  • Needs grooming first.
主要语言
C#
星标
1
派生
0
平均合并
2 小时 2 分钟
30 天内合并 PR
98

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

nevridge/TaskFlow 的其他 Issue

查看 nevridge/TaskFlow 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。