Fix child class methods shadowing parent methods

Open
#151 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp
Domain
backend

Research direction

Start by locating the project's clang-tidy configuration and the C++ methods reported by bugprone-derived-method-shadowing-base-method. Review each parent and child declaration to determine whether the parent function should be virtual, as the issue suggests. Run the project's relevant clang-tidy checks; done when the check is re-enabled and its reported issues are fixed.

Written by the indexing model from the issue text.

Description

enhancement

Re-enable clang-tidy's bugprone-derived-method-shadowing-base-method check and fix issues. Any issue here should probably be fixed by making the parent function virtual.

Dominant language
C++
Stars
18
Forks
9
Avg merge
2h 56m
Merged PRs (30d)
3

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nasa/cml

All issues in nasa/cml

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.