Polygon enclosure vertex check should be a static assert
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Find the PolygonEnclosure class and its initialize() function, then inspect how the vertex count is defined and checked. Move the minimum-three-vertices constraint into a class-level static_assert; done means invalid vertex counts fail at compile time.
Written by the indexing model from the issue text.
Description
The PolygonEnclosure::initialize() function checks that the number of vertices is at least 3. This is a constant known at compile-time. It should be turned into a static_assert in the class itself to prevent compilation if the class is used incorrectly.
- Dominant language
- C++
- Stars
- 18
- Forks
- 9
- Avg merge
- 2h 56m
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nasa/cml
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
infrastructure
Difficulty 1/5 Under an hour Newbie friendliness 72/100
-
Allow table interpolation model to accept moved vectorsMay be free again A pull request for this issue was closed without being merged. Openenhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Use std::size_tOpenenhancement
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Similar issues
-
bug priority:p2
Difficulty 1/5 Under an hour Newbie friendliness 82/100
xifan2333/fcitx5-vinput#738 ·
Maintainers usually reply within 1 day
-
good first issue hardware-report help wanted
Difficulty 1/5 Under an hour Newbie friendliness 66/100
-
need triaging
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
launcher: settings are never saved on macOS — QSettings SystemScope points to /Library/PreferencesOpen
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day