noq-proto: Retry Integrity Tag through the crypto provider, drop aes-gcm
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 40/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust
- Domain
- cryptography, networking
Research direction
Start in noq-proto's Cargo.toml, where aes-gcm is pulled in under the rustls feature, then find the Retry Integrity Tag computation that uses it. Check how the active crypto provider (ring or aws-lc-rs) exposes AEAD, and see how quinn-proto does it. Done means the tag is computed through the provider, aes-gcm is removed from the dependencies, and the RFC 9001 Appendix A.4 test vectors still pass. Confirm with a maintainer before starting, since the issue has no assignee and no decision yet.
Written by the indexing model from the issue text.
Description
With the rustls feature, noq-proto pulls in aes-gcm 0.10.3 only to compute the Retry Integrity Tag, whichever provider (ring or aws-lc-rs) is active. That brings a second cpufeatures (0.2) into graphs that already use 0.3, and an extra AES-GCM implementation.
Proposal: compute the tag through the active provider's own AEAD (quinn-proto 0.11.19 does the same with aws-lc-rs), and drop aes-gcm from the dependency list. The tests check it against RFC 9001 Appendix A.4's vectors.
We have it in a vendored copy. Would you take a PR?
- Dominant language
- Rust
- Stars
- 454
- Forks
- 98
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 19
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from n0-computer/noq
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
n0-computer/noq#892 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
n0-computer/noq#873 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
n0-computer/noq#872 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
n0-computer/noq#904 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 Half a day Newbie friendliness 68/100
n0-computer/noq#895 ·
Maintainers usually reply within 1 day
Similar issues
-
area:web kind:bug priority:p2 ready
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 84/100
sims1253/r-typeshed#140 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
storytold/craft-libs#2867 ·
Maintainers usually reply within 1 day
-
help wanted needs investigation priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 62/100