noq-proto: Retry Integrity Tag through the crypto provider, drop aes-gcm

Open
#880 2 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
40/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
rust

Research direction

Start in noq-proto's Cargo.toml, where aes-gcm is pulled in under the rustls feature, then find the Retry Integrity Tag computation that uses it. Check how the active crypto provider (ring or aws-lc-rs) exposes AEAD, and see how quinn-proto does it. Done means the tag is computed through the provider, aes-gcm is removed from the dependencies, and the RFC 9001 Appendix A.4 test vectors still pass. Confirm with a maintainer before starting, since the issue has no assignee and no decision yet.

Written by the indexing model from the issue text.

Description

ready-for-pr

With the rustls feature, noq-proto pulls in aes-gcm 0.10.3 only to compute the Retry Integrity Tag, whichever provider (ring or aws-lc-rs) is active. That brings a second cpufeatures (0.2) into graphs that already use 0.3, and an extra AES-GCM implementation.

Proposal: compute the tag through the active provider's own AEAD (quinn-proto 0.11.19 does the same with aws-lc-rs), and drop aes-gcm from the dependency list. The tests check it against RFC 9001 Appendix A.4's vectors.

We have it in a vendored copy. Would you take a PR?

Dominant language
Rust
Stars
454
Forks
98
Avg merge
2d 8h
Merged PRs (30d)
19

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from n0-computer/noq

All issues in n0-computer/noq

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.