fix(proto): BBR3 loses the app-limited mark when an ACK ends the previous period

Open Beginner friendly
#873 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
85/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
networking

Research direction

Start in congestion/bbr3/mod.rs at Bbr3::on_end_acks and inspect the existing BBR3 tests. Add a regression test for an ACK that ends one app-limited period while the sender remains app-limited. Done when the new period is marked and the test passes.

Written by the indexing model from the issue text.

Description

In Bbr3::on_end_acks (around congestion/bbr3/mod.rs:1743), clearing app_limited and setting it for the current round are joined with else if. When one ACK both ends the previous app-limited period and arrives while the sender is still app-limited, the new period isn't marked. Idle samples then count as bandwidth samples, and a mostly idle connection reaches full_bw_reached and leaves STARTUP early.

The fix is changing else if to a separate if, with a regression test. Happy to open a PR if this sounds right.

Version: noq-proto 1.4.0, still present on main (70fdbfa).

Dominant language
Rust
Stars
454
Forks
98
Avg merge
2d 8h
Merged PRs (30d)
19

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from n0-computer/noq

All issues in n0-computer/noq

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.