noq-proto: L4S support: configurable ECT(1) codepoint, echo validated against what was sent, CE bytes to the controller
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- rust, wasm
- Domain
- networking
Research direction
The ECN marking lives in poll_transmit in noq-proto, and validation is in detect_ecn, which currently rejects any ECT(1) increase in the peer's ACK. Read the config code for TransportConfig and the congestion Controller trait to see where ecn_codepoint and on_ecn would sit. Done means ECT(1) can be configured and validated against the codepoint actually sent, with the ecn_validation_* tests and a CE-bytes test passing.
Written by the indexing model from the issue text.
Description
noq-proto marks every packet ECT(0) (poll_transmit), and detect_ecn treats any ECT(1) increase in the peer's ACK as "ECN corruption". So an application can't use L4S (RFC 9330/9331): it can't send ECT(1), and if it did, validation would turn ECN off at the first ACK. The congestion controller also never learns how many of the acked bytes were CE-marked, which an L4S (scalable) controller needs.
Proposal:
TransportConfig::ecn_codepoint(EcnCodepoint), defaultEct0, so nothing changes for existing users. It's stored per path, anddetect_ecnvalidates the echo against the codepoint actually sent (RFC 9000 §13.4.2.1; withEct0this is exactly today's rule).Controller::on_ecn(acked_bytes, ce_bytes), a default no-op called for every validated ECN block.
We have both working in a vendored copy, with tests (ecn_validation_*, a CE-bytes test). Would you take a PR, or two PRs if you'd rather split them? Happy to adjust the API shape.
- Dominant language
- Rust
- Stars
- 454
- Forks
- 98
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 19
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from n0-computer/noq
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
n0-computer/noq#892 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
n0-computer/noq#873 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
n0-computer/noq#872 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
n0-computer/noq#904 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 Half a day Newbie friendliness 68/100
n0-computer/noq#895 ·
Maintainers usually reply within 1 day
Similar issues
-
area:web kind:bug priority:p2 ready
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 84/100
sims1253/r-typeshed#140 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
storytold/craft-libs#2867 ·
Maintainers usually reply within 1 day
-
help wanted needs investigation priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 62/100