noq-proto: expose RttEstimator's latest RTT sample for delay-based detectors
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- rust
- Domain
- networking
Research direction
Start in noq-proto's RTT estimator module, where RttEstimator's get(), conservative() and min() are defined and where update applies the RFC 9002 §5.3 adjusted_rtt. Add latest(), latest_adjusted() and a samples() counter without changing behaviour, then expose Connection::rtt_estimator(path_id). Done means the new accessors return the per-ACK sample under tests, with no allocation added.
Written by the indexing model from the issue text.
Description
RttEstimator exposes get(), conservative() and min(), but not the per-ACK sample they are built from. A queue-delay detector, such as the classic-ECN AQM fallback of RFC 9331 §4.3 (Linux TCP Prague runs it on every ACK), needs each sample with its own gain, not the 1/8-gain smoothed value.
Proposal, no behaviour change and no allocation:
RttEstimator::latest(),latest_adjusted()(RFC 9002 §5.3'sadjusted_rtt, the valueupdatealready uses) and asamples()count, so a caller that polls once per tick can tell a new sample from one it has seen;Connection::rtt_estimator(path_id) -> Option<RttEstimator>;- optionally
latest_less_ack_delay(): the sample less the declared ack delay without §5.3'smin_rttguard (Nonefor Initial/Handshake ACKs). The guard is right for PTO, but when a peer holds every ACK for a fixed time (a server that answers on its tick), the hold lands inmin_rttand the guard then keeps every sample whole, so the hold reads as a standing queue.
We run this in a vendored copy with tests. Would you take a PR? If you prefer push over poll, a Controller hook would work for us too.
- Dominant language
- Rust
- Stars
- 454
- Forks
- 98
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 19
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from n0-computer/noq
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
n0-computer/noq#892 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
n0-computer/noq#873 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
n0-computer/noq#872 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
n0-computer/noq#904 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 Half a day Newbie friendliness 68/100
n0-computer/noq#895 ·
Maintainers usually reply within 1 day
Similar issues
-
area:web kind:bug priority:p2 ready
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 84/100
sims1253/r-typeshed#140 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
storytold/craft-libs#2867 ·
Maintainers usually reply within 1 day
-
help wanted needs investigation priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 62/100