BBRv3: keepalives on an idle connection collapse max_bw
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust
- Domain
- networking
Research direction
Read the BBRv3 on_end_acks logic shown in the issue and compare it with the corresponding code in quinn-rs/quinn#2481. The issue describes a regression test on a simulated 100Mbit/s, 50ms link with 1s keepalives for 5 minutes; use that scenario to check whether max_bw stays near its initial value after the fix.
Written by the indexing model from the issue text.
Description
In on_end_acks:
if self.app_limited != 0 && self.delivered > self.app_limited {
self.app_limited = 0;
} else if app_limited {
self.app_limited = Ord::max(self.delivered + self.inflight, 1);
}
When the ack that clears the marker arrives while the sender is still idle, the else skips re-marking it. The next keepalive sample is then not app-limited, so it goes into the max_bw filter. After a few minutes of keepalives only, max_bw has aged out to roughly the keepalive rate, and the first transfer after idle starts from almost nothing.
We hit this in towonel after switching to BBRv3: page loads after a couple of minutes idle are ~200KB/s vs ~1MB/s on Cubic.
The fix is to drop the else (clear and re-mark are independent). I have a branch with the fix and a regression test: on a simulated 100Mbit/s, 50ms link, 5 min of 1s keepalives takes max_bw from 11.9MB/s to 800B/s before the fix, and it stays put after. Happy to open a PR if this sounds right.
Same code is in quinn-rs/quinn#2481.
- Dominant language
- Rust
- Stars
- 454
- Forks
- 98
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 19
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from n0-computer/noq
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
n0-computer/noq#892 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
n0-computer/noq#873 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
n0-computer/noq#872 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
n0-computer/noq#904 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 Half a day Newbie friendliness 68/100
n0-computer/noq#895 ·
Maintainers usually reply within 1 day
Similar issues
-
area:web kind:bug priority:p2 ready
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 84/100
sims1253/r-typeshed#140 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
storytold/craft-libs#2867 ·
Maintainers usually reply within 1 day
-
help wanted needs investigation priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 62/100