Schedule keep-alive PINGs from the negotiated idle timeout instead of a fixed interval
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 38/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- rust
- Domain
- networking
Research direction
Start by tracing noq's keep-alive-interval handling and where the peer's negotiated max_idle_timeout becomes available. Compare the current fixed re-arming behavior with the proposed RTT-aware deadline, then define tests showing that PINGs are scheduled from the negotiated timeout without spamming active connections.
Written by the indexing model from the issue text.
Description
This is an old Quinn behavior that I imagine hasn't been fixed yet. Low priority, just something that annoyed me about Quinn when I was brainstorming improvements.
We want fairly aggressive keep-alives in MoQ. But we also don't want to spam a shitload of PING packets. The keep-alive-interval knob in Quinn/noq is a fixed interval re-armed on every received packet (so ACKed STREAM traffic does hold it off), but it is blind to the peer's max_idle_timeout.
IMO keep-alives should only be sent when needed, and based on the time until the connection will close. Like if the peer says the max_idle_timeout (in setup) is 30s then we should PING based on how close we are to that deadline. The current setting is blind to what the peer wants, so you might configure an interval of 10s keep-alive pings and if the peer says max_idle_timeout is 8s, then you might get very unlucky.
So yeah, I almost feel like keep-alives should be built into noq based. Send PING packets some multiples of RTT close to max_idle_timeout.
- Dominant language
- Rust
- Stars
- 454
- Forks
- 98
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 19
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from n0-computer/noq
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
n0-computer/noq#892 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
n0-computer/noq#873 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
n0-computer/noq#872 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
n0-computer/noq#904 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 Half a day Newbie friendliness 68/100
n0-computer/noq#895 ·
Maintainers usually reply within 1 day
Similar issues
-
area:web kind:bug priority:p2 ready
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 84/100
sims1253/r-typeshed#140 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
storytold/craft-libs#2867 ·
Maintainers usually reply within 1 day
-
help wanted needs investigation priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 62/100