Verify eslint-env inline configuration comments/globals are still necessary
Maintainers usually reply within 12 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 50/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- webpack
- Domain
- build-system, tooling
Research direction
Inspect the webpack configuration files and the current flat ESLint configuration. Cross-reference each eslint-env comment's environments and globals, remove only comments that are already represented elsewhere, and verify that the warnings no longer occur before the ESLint v10 upgrade.
Written by the indexing model from the issue text.
Description
Before upgrading to ESLint v10 there will be a few warnings to look into. Apparently eslint-env comments in the webpack configs are still considered part of the eslintrc (non-flat) era:
ESLintEnvWarning:
/* eslint-env */comments are no longer recognized when linting with flat config and will be reported as errors as of v10.0.0. Replace them with/* global */comments or define globals in your config file. See https://eslint.org/docs/latest/use/configure/migration-guide#eslint-env-configuration-comments for details.
Quickly checking I think these are already correctly configured in the right places from when Alex migrated to the new config style, so it may just be as simple as removing these remnants — but I'll cross-reference the values and environments first, to check it's actually 1:1 mapped already, or there are deviations worth mentioning.
- Dominant language
- SCSS
- Stars
- 299
- Forks
- 83
- Avg merge
- 10d 2h
- Merged PRs (30d)
- 21
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mozilla/protocol
-
A11y ♿️
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 12 days
-
Bug :beetle: Size: XS
Difficulty 2/5 Under an hour Newbie friendliness 65/100
Maintainers usually reply within 12 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
Maintainers usually reply within 12 days
-
Dev ready ⚙️ P1 Size: XS
Difficulty 5/5 Over a week Newbie friendliness 35/100
mozilla/protocol#1119 · 2 comments ·
Maintainers usually reply within 12 days
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
Maintainers usually reply within 12 days
All issues in mozilla/protocol
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
AppImage/appimage.github.io#9676 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Cocoanetics/SwiftBash#95 ·
-
Xcode 27Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
airbnb/HorizonCalendar#349 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
OpenwaterHealth/openmotion-bloodflow-app#696 · 4 comments ·
Maintainers usually reply within 1 day
-
package-update
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
oSoWoSo/vOid_Community_repOsitory#240 · 1 comment ·
Maintainers usually reply within 1 day