Refactor notification bar 'close' function for IE support

Open Beginner friendly
#538 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
Under an hour
Newbie friendliness
65/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
frontend

Research direction

Search the notification bar implementation for e.currentTarget.parentNode.remove() and inspect the surrounding close handler. Replace the unsupported removal call with the requested removeChild() approach, then verify that closing the notification bar still works in the supported browsers, especially IE.

Written by the indexing model from the issue text.

Description

Bug :beetle: Size: XS

Description

In #534 it was noted that the function to close the notification bar is not supported in IE.
e.currentTarget.parentNode.remove(), we should refactor this to removeChild()

Dominant language
SCSS
Stars
298
Forks
83
Avg merge
8d 2h
Merged PRs (30d)
5

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla/protocol

All issues in mozilla/protocol

Similar issues

More Web Dev issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.