Consider replacing deprecated `clip`
Maintainers usually reply within 12 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- scss
- Domain
- frontend
Research direction
Start with the visually-hidden helper in assets/sass/protocol/includes/mixins/_utils.scss at the referenced lines, then review the stylelint-config-standard-scss failure from the linked workflow. Check the linked Mozilla bedrock usages for assumptions about the current clip value. Done means the deprecated syntax is addressed, lint passes, and any consumer migration impact is documented.
Written by the indexing model from the issue text.
Description
Description
The visually-hidden helper includes an outdated syntax of clip: rect() that may need replacing with some other clipping properties or maybe updating the helper to something more current overall.
Steps to reproduce
The next stylelint-config-standard-scss major version won't like it.
😭 /actions/runs/17982808350/job/51153182926 ✂️
Expected result
https://developer.mozilla.org/en-US/docs/Web/CSS/clip
Actual result
Environment
This might be breaking of sorts, in case a consumer applies the mixin, but then e.g. redefines or undoes the visual hiding in some cases, changing the clip value there — so there might be a migration to the newer mixin content version necessary for them.
- Dominant language
- SCSS
- Stars
- 299
- Forks
- 83
- Avg merge
- 10d 2h
- Merged PRs (30d)
- 21
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mozilla/protocol
-
A11y ♿️
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 12 days
-
Bug :beetle: Size: XS
Difficulty 2/5 Under an hour Newbie friendliness 65/100
Maintainers usually reply within 12 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
Maintainers usually reply within 12 days
-
Dev ready ⚙️ P1 Size: XS
Difficulty 5/5 Over a week Newbie friendliness 35/100
mozilla/protocol#1119 · 2 comments ·
Maintainers usually reply within 12 days
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
Maintainers usually reply within 12 days
All issues in mozilla/protocol
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
grimmory-tools/grimmory#2850 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Community-VyProjects/VyManager#908 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
AstrBotDevs/AstrBot#10340 ·
Maintainers usually reply within 1 day