As a developer, I would like an example of how to place the toolbar at the top of the screen so that I can easily add a toolbar position switch to my settings (like Fenix)

Open
#2,091 0 comments 1 reaction 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
android, kotlin
Domain
mobile-dev

Research direction

Start by reviewing the linked commit and the reference browser's BrowserToolbar, engineView layout, and settings entry points. Reproduce toolbar placement at the top, then verify that engineView content is not covered and that no bottom margin appears when scrolling; a settings switch should demonstrate the position change.

Written by the indexing model from the issue text.

Description

🌟 feature

The reference browser defaults to placing the BrowserToolbar at the bottom of the screen. However, as a developer, I would like to allow user's to switch the position of the toolbar. I attempted doing this in what seems like the "right" way in a fork, see this commit, https://github.com/paidforby/reference-browser/commit/dc9656ebb8b085c155ebc902a397eb41e2e35708. But this results in two problems:

  1. The top part of the engineView content is covered by the toolbar
  2. When scrolling down the page, the toolbar hides as expected, but a margin pops up at the bottom of the screen, cutting off the bottom of the engineView content.

I will be satisfied if solutions are provided for these issues. Ideally, a simple switch preference should be added to the reference browser settings that changes the position of the toolbar for demonstrative purposes.

Dominant language
Kotlin
Stars
668
Forks
198
Avg merge
8h 47m
Merged PRs (30d)
53

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla-mobile/reference-browser

All issues in mozilla-mobile/reference-browser

Similar issues

More Kotlin issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.