As a developer, I would like an example of how to place the toolbar at the top of the screen so that I can easily add a toolbar position switch to my settings (like Fenix)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Domain
- mobile-dev
Research direction
Start by reviewing the linked commit and the reference browser's BrowserToolbar, engineView layout, and settings entry points. Reproduce toolbar placement at the top, then verify that engineView content is not covered and that no bottom margin appears when scrolling; a settings switch should demonstrate the position change.
Written by the indexing model from the issue text.
Description
The reference browser defaults to placing the BrowserToolbar at the bottom of the screen. However, as a developer, I would like to allow user's to switch the position of the toolbar. I attempted doing this in what seems like the "right" way in a fork, see this commit, https://github.com/paidforby/reference-browser/commit/dc9656ebb8b085c155ebc902a397eb41e2e35708. But this results in two problems:
- The top part of the engineView content is covered by the toolbar
- When scrolling down the page, the toolbar hides as expected, but a margin pops up at the bottom of the screen, cutting off the bottom of the engineView content.
I will be satisfied if solutions are provided for these issues. Ideally, a simple switch preference should be added to the reference browser settings that changes the position of the toolbar for demonstrative purposes.
- Dominant language
- Kotlin
- Stars
- 668
- Forks
- 198
- Avg merge
- 8h 47m
- Merged PRs (30d)
- 53
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mozilla-mobile/reference-browser
-
🐞 bug
Difficulty 1/5 Under an hour Newbie friendliness 55/100
mozilla-mobile/reference-browser#4174 ·
Maintainers usually reply within 1 day
-
🐞 bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
mozilla-mobile/reference-browser#4072 ·
Maintainers usually reply within 1 day
-
Snackbars have wrong anchoring / paddingMay be free again A pull request for this issue was closed without being merged. Open🐞 bug
Difficulty 3/5 1-2 days Newbie friendliness 42/100
mozilla-mobile/reference-browser#3746 · 1 comment ·
Maintainers usually reply within 1 day
-
🐞 bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
mozilla-mobile/reference-browser#3083 · 1 comment ·
Maintainers usually reply within 1 day
-
🐞 bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
mozilla-mobile/reference-browser#2538 ·
Maintainers usually reply within 1 day
All issues in mozilla-mobile/reference-browser
Similar issues
-
Bug Domain changed
Difficulty 1/5 Under an hour Newbie friendliness 79/100
keiyoushi/extensions-source#21174 ·
Maintainers usually reply within 1 day
-
Unified account interface not translated into Simplified ChinesePossibly taken @xuenhua claimed this 3 days ago. Openunconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
thunderbird/thunderbird-android#11936 · 1 comment ·
Maintainers usually reply within 3 days
-
Update toast stylingOpendesign good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
scribe-org/Scribe-Android#778 ·
Maintainers usually reply within 1 day
-
Needs Triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ankidroid/Anki-Android#23392 ·
Maintainers usually reply within 1 day
-
AI Generated CI/CD ⚒️ Flaky-tests 🐦 go 🏃
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
valkey-io/valkey-glide#7772 ·
Maintainers usually reply within 1 day