Remove saved-variable migrations and compat code before the Forever beta ends (Oct 21)

Open
  • Is something wrong?
#64 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
Half a day
Newbie friendliness
50/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
lua
Domain
game-dev

Research direction

The two known spots are s.historySize = nil in AuctionDB.lua and the LOGIN handler in Comm.lua, which holds the old all-faction sv.trusted list, the one-time notice and the v == true name entries. Start by reading those blocks and any other saved-variable loading code, and list every compat path you find. Done means those paths are gone, the addon still loads with current saved variables, and it has been checked in game before the Oct 21 beta cutoff.

Written by the indexing model from the issue text.

Description

Saved variables from the beta won't carry over to the release, so the migration code can go. Do it around Oct 18-19, while it can still be tested in game: the beta ends Oct 21, 2026 and the release is Nov 4.

Known so far:

  • AuctionDB.lua: s.historySize = nil
  • Comm.lua LOGIN: old all-faction sv.trusted list, the one-time notice and the v == true name entries

Add to this list as more compat code shows up.

Dominant language
Lua
Stars
23
Forks
6
Avg merge
56m
Merged PRs (30d)
24

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mooreatv/AuctionDB

All issues in mooreatv/AuctionDB

Similar issues

More Lua issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.