Calling an unknown tool logs a server-side Error "threw an unhandled exception"
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 75/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- csharp
- Domain
- backend-api-design
Research direction
Start in src/ModelContextProtocol.Core/Server/McpServerImpl.cs, tracing the unknown-tool handler and the BuildInitialAlternateToolFilter and LogToolCallLifecycles paths that call ToolCallError. Compare this path with the existing Logs_Tool_Error_When_Tool_Throws_McpProtocolException test. Done means an unknown tool still returns JSON-RPC -32602 without an Error log, while an exception thrown by a tool remains logged at Error.
Written by the indexing model from the issue text.
Description
Summary
When a client calls a tool that does not exist, the server answers correctly with JSON-RPC -32602 (Unknown tool: '…'), but it also writes a server-side Error with a stack trace:
fail: "no_such_tool" threw an unhandled exception.
ModelContextProtocol.McpProtocolException: Unknown tool: 'no_such_tool'
The cause is input from the client, not a fault of the server, yet it looks like a crash in logs, APM and alerting. Any client (or a model that hallucinates a tool name) can produce these Errors at will.
Where (2.4.0, unchanged on main)
src/ModelContextProtocol.Core/Server/McpServerImpl.cs
- The default handler throws
new McpProtocolException($"Unknown tool: '{name}'", McpErrorCode.InvalidParams)(line ~1603). BuildInitialAlternateToolFilter(line ~1737) andLogToolCallLifecycles(line ~1787) callToolCallError(LogLevel.Error, "threw an unhandled exception.") for every exception except cancellation andInputRequiredException, including thisMcpProtocolException, and then rethrow it as the protocol error.
Reproduction
Server with any tool, client calls tools/call with the name no_such_tool. Expected: -32602 to the client, no Error on the server. Actual: -32602 and the Error above.
Context
Logs_Tool_Error_When_Tool_Throws_McpProtocolException asserts that an McpProtocolException thrown by a tool is logged at Error, so I understand that is intended. The unknown-tool case is different: no tool ran, and the exception comes from the SDK's own validation of the request.
Proposal
Do not log ToolCallError when no tool was matched for the request (the SDK's own unknown-tool path), or log it at Debug/Information like ToolCallCompleted. The protocol error to the client stays as it is.
Workaround we use today: an incoming message filter (WithMessageFilters(f => f.AddIncomingFilter(...))) that answers tools/call for unknown names with -32602 before the tool pipeline runs. Happy to send a PR if the direction is acceptable.
- Dominant language
- C#
- Stars
- 4.6k
- Forks
- 849
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 24
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from modelcontextprotocol/csharp-sdk
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
modelcontextprotocol/csharp-sdk#2031 ·
Maintainers usually reply within 1 day
-
Static resources whose URIs differ only in the fragment or user info collapse into onePossibly taken @halter73 claimed this 10 days ago. OpenP2
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
modelcontextprotocol/csharp-sdk#1970 · 4 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
POST /mcp with a missing or unparseable Content-Type returns HTTP 500 instead of a 4xxPossibly taken @halter73 claimed this 10 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
modelcontextprotocol/csharp-sdk#1966 · 5 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
Reserved URI-template expansion throws for supplementary Unicode charactersPossibly taken @tarekgh claimed this 3 days ago. OpenP3
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
modelcontextprotocol/csharp-sdk#1913 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
ClaimsPrincipal parameter injection sample requestPossibly taken @utsavjain2809 claimed this 48 days ago. Openhelp wanted P3
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
modelcontextprotocol/csharp-sdk#1899 ·
Maintainers usually reply within 1 day
All issues in modelcontextprotocol/csharp-sdk
Similar issues
-
CLI: stale build hint, non-gofmt autocomplete output and a leftover `--revit=<year>` in the docsOpenCommand Line Utility (CLI)
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
pyrevitlabs/pyRevit#4217 ·
Maintainers usually reply within 1 day
-
area: ui bug ready
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
account bug effort:S P2
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nightscout/nocturne#3745 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
grate-devs/grate#969 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
jsboige/CoursIA#27768 · 2 comments ·
Maintainers usually reply within 1 day