Calling an unknown tool logs a server-side Error "threw an unhandled exception"

Open
#2,030 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
75/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
csharp

Research direction

Start in src/ModelContextProtocol.Core/Server/McpServerImpl.cs, tracing the unknown-tool handler and the BuildInitialAlternateToolFilter and LogToolCallLifecycles paths that call ToolCallError. Compare this path with the existing Logs_Tool_Error_When_Tool_Throws_McpProtocolException test. Done means an unknown tool still returns JSON-RPC -32602 without an Error log, while an exception thrown by a tool remains logged at Error.

Written by the indexing model from the issue text.

Description

Summary

When a client calls a tool that does not exist, the server answers correctly with JSON-RPC -32602 (Unknown tool: '…'), but it also writes a server-side Error with a stack trace:

fail: "no_such_tool" threw an unhandled exception.
ModelContextProtocol.McpProtocolException: Unknown tool: 'no_such_tool'

The cause is input from the client, not a fault of the server, yet it looks like a crash in logs, APM and alerting. Any client (or a model that hallucinates a tool name) can produce these Errors at will.

Where (2.4.0, unchanged on main)

src/ModelContextProtocol.Core/Server/McpServerImpl.cs

  • The default handler throws new McpProtocolException($"Unknown tool: '{name}'", McpErrorCode.InvalidParams) (line ~1603).
  • BuildInitialAlternateToolFilter (line ~1737) and LogToolCallLifecycles (line ~1787) call ToolCallError (LogLevel.Error, "threw an unhandled exception.") for every exception except cancellation and InputRequiredException, including this McpProtocolException, and then rethrow it as the protocol error.

Reproduction

Server with any tool, client calls tools/call with the name no_such_tool. Expected: -32602 to the client, no Error on the server. Actual: -32602 and the Error above.

Context

Logs_Tool_Error_When_Tool_Throws_McpProtocolException asserts that an McpProtocolException thrown by a tool is logged at Error, so I understand that is intended. The unknown-tool case is different: no tool ran, and the exception comes from the SDK's own validation of the request.

Proposal

Do not log ToolCallError when no tool was matched for the request (the SDK's own unknown-tool path), or log it at Debug/Information like ToolCallCompleted. The protocol error to the client stays as it is.

Workaround we use today: an incoming message filter (WithMessageFilters(f => f.AddIncomingFilter(...))) that answers tools/call for unknown names with -32602 before the tool pipeline runs. Happy to send a PR if the direction is acceptable.

Dominant language
C#
Stars
4.6k
Forks
849
Avg merge
1d 16h
Merged PRs (30d)
24

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from modelcontextprotocol/csharp-sdk

All issues in modelcontextprotocol/csharp-sdk

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.